Bump plugin util api to 2.20 to fix tests #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A field has been removed in edu.hm.hafner.util.ArchitectureRules in later versions of plugin-util-api causing compilation errors when run in PCT
This was referenced Dec 13, 2022
Codecov Report
@@ Coverage Diff @@
## main #72 +/- ##
=========================================
Coverage 75.80% 75.80%
Complexity 86 86
=========================================
Files 13 13
Lines 343 343
Branches 27 27
=========================================
Hits 260 260
Misses 79 79
Partials 4 4 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
The mutation coverage error seems consistent over all the PRs, not just mine. |
|
@uhafner any chance for a speedy review and release of this one as well? |
uhafner
requested changes
Dec 14, 2022
src/test/java/io/jenkins/plugins/prism/PluginArchitectureTest.java
Outdated
Show resolved
Hide resolved
src/test/java/io/jenkins/plugins/prism/PluginArchitectureTest.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Ullrich Hafner <ullrich.hafner@gmail.com>
uhafner
approved these changes
Dec 14, 2022
uhafner
approved these changes
Dec 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A field has been removed in
edu.hm.hafner.util.ArchitectureRulesin later versions of plugin-util-api causing compilation errors when run in PCT.Related to jenkinsci/warnings-ng-plugin#1425