Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align version of plugin-util-api plugin in test and compile dependencies #1425

Merged
merged 4 commits into from
Dec 14, 2022

Conversation

rsandell
Copy link
Member

@rsandell rsandell commented Dec 13, 2022

Tests and hpi runtime was using different versions causing test compilation errors when running with PCT.

Related: jenkinsci/prism-api-plugin#72

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Tests and hpi runtime was using different versions
causing test compilation errors when running with PCT
@codecov
Copy link

codecov bot commented Dec 13, 2022

Codecov Report

Merging #1425 (0a90b26) into master (03c7c67) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 0a90b26 differs from pull request most recent head 5821f1f. Consider uploading reports for the commit 5821f1f to get more accurate results

@@             Coverage Diff              @@
##             master    #1425      +/-   ##
============================================
+ Coverage     79.87%   79.88%   +0.01%     
- Complexity     1452     1461       +9     
============================================
  Files           252      252              
  Lines          5594     5622      +28     
  Branches        424      425       +1     
============================================
+ Hits           4468     4491      +23     
- Misses          976      981       +5     
  Partials        150      150              
Impacted Files Coverage Δ
...plugins/analysis/core/steps/ScanForIssuesStep.java 85.24% <0.00%> (-2.48%) ⬇️
...jenkins/plugins/analysis/core/util/LogHandler.java 100.00% <0.00%> (ø)
...ins/plugins/analysis/core/steps/IssuesScanner.java 93.54% <0.00%> (+0.08%) ⬆️
...plugins/analysis/core/steps/PublishIssuesStep.java 57.14% <0.00%> (+0.35%) ⬆️
...ns/plugins/analysis/core/steps/IssuesRecorder.java 68.01% <0.00%> (+0.59%) ⬆️
.../plugins/analysis/core/steps/RecordIssuesStep.java 60.66% <0.00%> (+0.95%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

.gitignore Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
Co-authored-by: Ullrich Hafner <ullrich.hafner@gmail.com>
@uhafner uhafner added the dependencies Update of dependencies label Dec 14, 2022
@uhafner uhafner changed the title Align Plugin Util Api version Align version of plugin-util-api plugin in test and compile dependencies Dec 14, 2022
@uhafner uhafner merged commit e6bb787 into jenkinsci:master Dec 14, 2022
@uhafner
Copy link
Member

uhafner commented Dec 14, 2022

Thanks!

@rsandell rsandell deleted the align-plugin-util-api branch December 14, 2022 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Update of dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants