-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align version of plugin-util-api plugin in test and compile dependencies #1425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests and hpi runtime was using different versions causing test compilation errors when running with PCT
6 tasks
Codecov Report
@@ Coverage Diff @@
## master #1425 +/- ##
============================================
+ Coverage 79.87% 79.88% +0.01%
- Complexity 1452 1461 +9
============================================
Files 252 252
Lines 5594 5622 +28
Branches 424 425 +1
============================================
+ Hits 4468 4491 +23
- Misses 976 981 +5
Partials 150 150
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
6 tasks
uhafner
requested changes
Dec 13, 2022
plugin/src/test/java/io/jenkins/plugins/analysis/warnings/PluginArchitectureTest.java
Outdated
Show resolved
Hide resolved
rsandell
commented
Dec 14, 2022
Co-authored-by: Ullrich Hafner <ullrich.hafner@gmail.com>
uhafner
requested changes
Dec 14, 2022
plugin/src/test/java/io/jenkins/plugins/analysis/warnings/PluginArchitectureTest.java
Outdated
Show resolved
Hide resolved
plugin/src/test/java/io/jenkins/plugins/analysis/warnings/PluginArchitectureTest.java
Outdated
Show resolved
Hide resolved
…inArchitectureTest.java Remove import.
…inArchitectureTest.java Fix CheckStyle problem.
uhafner
changed the title
Align Plugin Util Api version
Align version of plugin-util-api plugin in test and compile dependencies
Dec 14, 2022
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests and hpi runtime was using different versions causing test compilation errors when running with PCT.
Related: jenkinsci/prism-api-plugin#72