[JENKINS-26143] Tests #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
3 tasks
|
Failing test looks unrelated, probably a slightly outdated core that doesn't have jenkinsci/jenkins#3342 yet. |
abayer
reviewed
Mar 12, 2018
jglick
approved these changes
Mar 12, 2018
| @@ -64,7 +64,8 @@ THE SOFTWARE. | |||
| </pluginRepositories> | |||
| <properties> | |||
| <java.level>8</java.level> | |||
| <jenkins.version>2.62</jenkins.version> | |||
| <jenkins-core.version>2.111-20180312.014148-2</jenkins-core.version> | |||
| <jenkins-war.version>2.111-20180312.014313-2</jenkins-war.version> | |||
There was a problem hiding this comment.
You should also delete the now-older baseline from Jenkinsfile, thus simply:
buildPlugin()| @@ -99,6 +101,7 @@ | |||
| ParametersDefinitionProperty.DescriptorImpl.class.isAnnotationPresent(Symbol.class) && // "parameters" | |||
| BooleanParameterDefinition.DescriptorImpl.class.isAnnotationPresent(Symbol.class) && // "booleanParam" | |||
| StringParameterDefinition.DescriptorImpl.class.isAnnotationPresent(Symbol.class) && // "string" | |||
| ChoiceParameterDefinition.DescriptorImpl.class.isAnnotationPresent(Symbol.class) && // "choice" and "choiceParam" | |||
There was a problem hiding this comment.
Well clearly if we have this new core baseline, HAVE_SYMBOL == true, so we can just delete all these switches.
| @Test | ||
| public void testChoiceParameterSnippetizer() throws Exception { | ||
| //new SnippetizerTester(r).assertGenerateSnippet(); | ||
| new SnippetizerTester(r).assertRoundTrip(new JobPropertyStep(Arrays.asList(new ParametersDefinitionProperty(new ChoiceParameterDefinition[] { |
jglick
requested changes
Oct 5, 2018
|
Reminder that that does not mean this needs to be closed. Merging #81 would automatically mark this as merged as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion PR to core change jenkinsci/jenkins#3014
Built against jenkinsci/jenkins@7b8e4b1