Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-26143] [JENKINS-53917] Integration testing of ChoiceParameterDefinition #81

Merged

Conversation

jglick
Copy link
Member

@jglick jglick commented Oct 5, 2018

Subsumes #72 and serves as a testbed for JENKINS-53917.

…e test code still checking for lack of symbols in 1.x cores.
@jglick
Copy link
Member Author

jglick commented Oct 5, 2018

Windows tests are having difficulty with path lengths. jenkinsci/branch-api-plugin#129 would help, if only someone would review it…

@jglick jglick changed the title [JENKINS-26143] Integration testing of ChoiceParameterDefinition [JENKINS-26143] [JENKINS-53917] Integration testing of ChoiceParameterDefinition Oct 5, 2018
@@ -1 +1,2 @@
buildPlugin(jenkinsVersions: [null, '2.89.2'])
// TODO pending https://github.com/jenkinsci/branch-api-plugin/pull/129 Windows tests hit path length limits
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trying it out in #82.

@svanoort svanoort merged commit af95c21 into jenkinsci:master Nov 9, 2018
@jglick jglick deleted the ChoiceParameterDefinition-JENKINS-26143 branch November 9, 2018 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants