Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web UI fix missing units psm2 #2754

Merged

Conversation

PhilippEngler
Copy link
Contributor

Description

This PR will add the units (W) and the correct minimum and maximum values to the power threshold, lower threshold and higher threshold textboxes in the channel 7 for HmIP-PSM-2 and HmIP-PSM-2 QHJ devices.

Related Issue

This should solve #2746.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Alternate Designs

Possible Drawbacks

There might be a problem with the values. It could be that they require conversion (see #2746). During my tests, there was no need for conversion.

Verification Process

I have used the lower and higher values to values around the current power consumption. I have not run in any problems.

Release Notes

  • Fixed an issue where incorrect min/max values and no units where displayed in channel 7 for HmIP-PSM-2 and HmIP-PSM-2 QHJ devices.

Contributing checklist

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING and LICENSE document.
  • I fully agree to distribute my changes under Apache 2.0 license.

PhilippEngler and others added 3 commits May 25, 2024 13:54
Added the missing units and correct min and max values for channel 7.
changed max value to 3000W because ps,-2 and psm-2 qhj does not support 3680W
@jens-maus jens-maus added 💡 enhancement-ideas New feature or change request 🏷️ WebUI This refs the WebUI component labels May 26, 2024
@jens-maus jens-maus added this to the next release milestone May 26, 2024
@jens-maus jens-maus linked an issue May 26, 2024 that may be closed by this pull request
@jens-maus jens-maus added 🐛 bug-report Something isn't working and removed 💡 enhancement-ideas New feature or change request labels May 26, 2024
@jens-maus jens-maus merged commit 9d0c216 into jens-maus:master May 26, 2024
9 checks passed
@PhilippEngler
Copy link
Contributor Author

@jens-maus: thank you and please excuse my mistake. I will be more careful next time.

@jens-maus
Copy link
Owner

No problem. The procedure how to create a proper WebUI patch is unfortunately quite cumbersome and also undocumented...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug-report Something isn't working 🏷️ WebUI This refs the WebUI component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HmIP-PSM-2 QHJ Einheit der Grenzwerte fehlt
2 participants