Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

equalsIgnoreCase instead of equals #1

Closed
bedirhan opened this issue Nov 19, 2012 · 5 comments
Closed

equalsIgnoreCase instead of equals #1

bedirhan opened this issue Nov 19, 2012 · 5 comments

Comments

@bedirhan
Copy link

testAnalyze of org.codesecure.dependencycheck.analyzer.JarAnalyzerTest line 75 uses equals for string comparison which fails the "implementation-url" comparison. I've changed that to equalsIgnoreCase and compiled successtully.

        if (e.getName().equalsIgnoreCase("implementation-url") && e.getValue().equals("http://jetty.mortbay.org")) {
            found = true;
            break;
        }
@jeremylong
Copy link
Owner

I will take care of this shortly.

@jmanico
Copy link

jmanico commented Nov 20, 2012

What a sweet tool Jeremy.....

Jim Manico
(808) 652-3805

On Nov 20, 2012, at 4:11 AM, Jeremy Long notifications@github.com wrote:

I will take care of this shortly.


Reply to this email directly or view it on
GitHubhttps://github.com//issues/1#issuecomment-10555672.

@jeremylong
Copy link
Owner

Thanks for reporting this; the issue is now fixed.

@bedirhan
Copy link
Author

no problem. thanks for the quick response.

stevespringett pushed a commit that referenced this issue Mar 26, 2015
Update from jeremylong/DependencyCheck
jeremylong pushed a commit that referenced this issue Mar 8, 2016
fixed trigger compilation and added version number
jeremylong pushed a commit that referenced this issue Oct 9, 2016
@lock
Copy link

lock bot commented Sep 28, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Sep 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants