feat(valid-title): allow custom matcher messages #913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason using `patternProperties` seems to make `undefined` an invalid value for the two properties, but not too fussed over this because that was only there for coverage in the first place.
SimenB
approved these changes
Sep 29, 2021
github-actions bot
pushed a commit
that referenced
this pull request
Sep 29, 2021
# [24.5.0](v24.4.3...v24.5.0) (2021-09-29) ### Bug Fixes * **no-deprecated-functions:** remove `process.cwd` from resolve paths ([#889](#889)) ([6940488](6940488)) * **no-identical-title:** always consider `.each` titles unique ([#910](#910)) ([a41a40e](a41a40e)) ### Features * create `prefer-expect-resolves` rule ([#822](#822)) ([2556020](2556020)) * create `prefer-to-be` rule ([#864](#864)) ([3a64aea](3a64aea)) * **require-top-level-describe:** support enforcing max num of describes ([#912](#912)) ([14a2d13](14a2d13)) * **valid-title:** allow custom matcher messages ([#913](#913)) ([ffc9392](ffc9392))
|
🎉 This PR is included in version 24.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
github-actions bot
pushed a commit
that referenced
this pull request
Sep 29, 2021
# [25.0.0-next.5](v25.0.0-next.4...v25.0.0-next.5) (2021-09-29) ### Bug Fixes * **no-deprecated-functions:** remove `process.cwd` from resolve paths ([#889](#889)) ([6940488](6940488)) * **no-identical-title:** always consider `.each` titles unique ([#910](#910)) ([a41a40e](a41a40e)) * **valid-expect-in-promise:** support `finally` ([#914](#914)) ([9c89855](9c89855)) * **valid-expect-in-promise:** support additional test functions ([#915](#915)) ([4798005](4798005)) ### Features * create `prefer-expect-resolves` rule ([#822](#822)) ([2556020](2556020)) * create `prefer-to-be` rule ([#864](#864)) ([3a64aea](3a64aea)) * **require-top-level-describe:** support enforcing max num of describes ([#912](#912)) ([14a2d13](14a2d13)) * **valid-title:** allow custom matcher messages ([#913](#913)) ([ffc9392](ffc9392))
|
🎉 This PR is included in version 25.0.0-next.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm wondering if maybe we should drop support for taking a string in favor of always passing a tuple (with or without the second item), as it'd make things a bit lighter for us by making the usage more consistent (both in code and docs) 🤔
I think a good follow-up feature would be to support multiple matchers, so that you can reduce the complexity of single regexps + have more specific messages (implementation wise, this'd be that we support taking in an array of
MatcherAndMessage& change our logic to do iterate over eachMatcherAndMessage).Slightly annoyingly, we could almost deprecate
lowercase-namein favor of this rule since you could use/[^A-Z]/u.sourceexcept that would also apply to top-level describes.Fixes #688