Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use eslint-plugin-import #3423

Merged
merged 1 commit into from
May 11, 2017
Merged

Use eslint-plugin-import #3423

merged 1 commit into from
May 11, 2017

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Apr 30, 2017

Summary
Mentioned here: #2859 (comment)

Test plan
yarn lint

@@ -17,5 +17,8 @@
"jest-snapshot": "^19.0.2",
"once": "^1.4.0",
"p-map": "^1.1.1"
},
"devDependencies": {
"jest-runtime": "^19.0.3"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added because of a type import. Should all types only exist in types/?

@codecov-io
Copy link

codecov-io commented Apr 30, 2017

Codecov Report

Merging #3423 into master will increase coverage by 0.03%.
The diff coverage is 92.39%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3423      +/-   ##
==========================================
+ Coverage   62.25%   62.28%   +0.03%     
==========================================
  Files         181      181              
  Lines        6716     6714       -2     
  Branches        6        6              
==========================================
+ Hits         4181     4182       +1     
+ Misses       2532     2529       -3     
  Partials        3        3
Impacted Files Coverage Δ
packages/jest-editor-support/src/Runner.js 76.19% <ø> (ø) ⬆️
packages/jest-editor-support/src/Settings.js 100% <ø> (ø) ⬆️
packages/jest-cli/src/jest.js 0% <0%> (ø) ⬆️
packages/jest-environment-jsdom/src/index.js 0% <0%> (ø) ⬆️
packages/jest-util/src/index.js 0% <0%> (ø) ⬆️
packages/jest-util/src/Console.js 0% <0%> (ø) ⬆️
packages/jest-cli/src/runJest.js 0% <0%> (ø) ⬆️
packages/jest-jasmine2/src/index.js 0% <0%> (ø) ⬆️
...est-test-typescript-parser/src/TypeScriptParser.js 100% <100%> (ø) ⬆️
packages/jest-cli/src/TestRunner.js 30.28% <100%> (ø) ⬆️
... and 42 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb24412...a5104c2. Read the comment docs.

@SimenB
Copy link
Member Author

SimenB commented Apr 30, 2017

Pushed a commit disabling max-len eslint rule as well. With prettier handling it, I don't really see why we should litter the code base with disables for strings, comments, and regexps. Can remove (or move to another PR) if you want, of course 😄

@cpojer
Copy link
Member

cpojer commented May 11, 2017

Seems like this one conflicts with pretty much everything, so we'll need to redo this PR :(

@SimenB
Copy link
Member Author

SimenB commented May 11, 2017

I can redo it 😄

Seems like max-len stuff was done in #3444

@cpojer cpojer merged commit 73368b1 into jestjs:master May 11, 2017
@cpojer
Copy link
Member

cpojer commented May 11, 2017

Woohoo, thanks!

@SimenB SimenB deleted the eslint-import branch May 11, 2017 13:16
orta pushed a commit to orta/jest that referenced this pull request Jul 7, 2017
tushardhole pushed a commit to tushardhole/jest that referenced this pull request Aug 21, 2017
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants