Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate jetty-osgi-servlet-api artifact to jetty-servlet-api #20

Closed
joakime opened this issue Nov 20, 2018 · 11 comments
Closed

Migrate jetty-osgi-servlet-api artifact to jetty-servlet-api #20

joakime opened this issue Nov 20, 2018 · 11 comments
Assignees

Comments

@joakime
Copy link
Contributor

joakime commented Nov 20, 2018

Along with the required build fixes from #18, we should perform the necessary steps from jetty/jetty.project#3120 to bring this artifact up to speed for JPMS as well.

Current tasks:

@sbordet
Copy link
Contributor

sbordet commented Nov 22, 2018

@joakime while we're at it, we need to add Automatic-Module-Name: jetty.servlet.api to the manifest, so Jetty 10.0.x can properly reference it.
See jetty/jetty.project#2989.

@joakime
Copy link
Contributor Author

joakime commented Nov 26, 2018

Example of new generated META-INF/MANIFEST.MF

Manifest-Version: 1.0
Automatic-Module-Name: jetty-servlet-api
Bnd-LastModified: 1543251475166
Build-Jdk: 9
Built-By: joakim
Bundle-Description: Combined servlet api and schemas for use in JPMS and
  OSGi environments
Bundle-DocURL: http://www.mortbay.com
Bundle-License: http://www.apache.org/licenses/LICENSE-2.0, http://www.e
 clipse.org/org/documents/epl-v10.php
Bundle-ManifestVersion: 2
Bundle-Name: Jetty Servlet API and Schemas for JPMS and OSGi
Bundle-RequiredExecutionEnvironment: JavaSE-1.7
Bundle-SymbolicName: org.eclipse.jetty.osgi-servlet-api
Bundle-Vendor: Mort Bay Consulting
Bundle-Version: 4.0.0.SNAPSHOT
Created-By: Apache Maven Bundle Plugin
Implementation-Vendor: Eclipse.org - Jetty
Implementation-Version: 4.0-SNAPSHOT
Tool: Bnd-3.5.0.201709291849
url: http://www.eclipse.org/jetty

@sbordet
Copy link
Contributor

sbordet commented Nov 26, 2018

Should not we require JavaSE-1.8?

@joakime
Copy link
Contributor Author

joakime commented Nov 26, 2018

the JavaSE-1.7 update to the OSGi environment settings for Servlet API 4.0 was done by @janbartel in commit 46bd54b
Didn't feel appropriate to adjust that.

@sbordet
Copy link
Contributor

sbordet commented Nov 26, 2018

But Servlet 4.0 requires JDK 8 (Section 1.2).

@joakime
Copy link
Contributor Author

joakime commented Nov 26, 2018

@sbordet the SNAPSHOT for this approach is available on the jetty-snapshots repo if you want to give it a whirl.

https://oss.sonatype.org/content/repositories/jetty-snapshots/

<dependency>
  <groupId>org.eclipse.jetty.toolchain</groupId>
  <artifactId>jetty-servlet-api</artifactId>
  <version>4.0-SNAPSHOT</version>
</dependency>

This was deployed from the jetty-servlet-api-4.0-jpms branch.

@joakime
Copy link
Contributor Author

joakime commented Nov 26, 2018

PR #22 opened for this Issue.

@sbordet
Copy link
Contributor

sbordet commented Nov 29, 2018

@joakime the Automatic-Module-Name is wrong, as module names cannot contain the - character.
Can you please use jetty.servlet.api?

sbordet added a commit that referenced this issue Nov 29, 2018
Updated version to 4.0.0-SNAPSHOT.
Updated Maven Plugins and dependencies versions.
Fixed Automatic-Module-Name to jetty.servlet.api.
Updated OSGi required environment to JavaSE-1.8.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
sbordet added a commit that referenced this issue Nov 30, 2018
Now producing a reduced POM without dependencies.
Fixed Export-Package directive.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
joakime added a commit that referenced this issue Nov 30, 2018
@cowwoc
Copy link

cowwoc commented Aug 28, 2019

I believe that jakartaee/servlet#201 is fixed. You should be able to use the artifact that was released 6 days ago, instead of the Jetty-specific fork.

@joakime
Copy link
Contributor Author

joakime commented Aug 28, 2019

@cowwoc unfortunately, the Jakarta specific release is missing the required embedded schemas wont work equally as well on both osgi and jpms.

@joakime
Copy link
Contributor Author

joakime commented Feb 4, 2020

This work has been completed

@joakime joakime closed this as completed Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants