New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Jetty specific Servlet API jar #3162

Closed

sbordet opened this issue Nov 29, 2018 · 1 comment

Milestone

Contributor

sbordet commented Nov 29, 2018

Jetty is currently using the official javax.servlet:javax.servlet-api:4.0.1 dependency.
However, that dependency does not play well with JPMS since it lacks the XML schema definitions that are loaded from ServletContext.
Furthermore, it does not have a proper JPMS module name.

Other projects have already repackaged the official Servlet API jar into their own, and we should do so as well rather than waiting for a JakartaEE release which may take a long time.

See also jetty/jetty-toolchain#20 and #2989.

The text was updated successfully, but these errors were encountered:

sbordet added this to the 10.0.x milestone

sbordet added a commit that referenced this issue


          Issue #3162 - Use Jetty specific Servlet API jar.

bfa2dbf

* Updated module-info.java to reference the "jetty.servlet.api" module.
* Updated POMs to reference the o.e.j.toolchain:jetty-servlet-api artifact.
* Removed references to jetty-schemas.jar.
* Updated attribute "org.eclipse.jetty.server.webapp.ContainerIncludeJarPattern"
  to match the new Jetty Servlet API jar.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>

sbordet added a commit that referenced this issue


          Issue #3162 - Use Jetty specific Servlet API jar.

707c9ec

Future proof reference of the jetty-servlet-api.jar.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>

sbordet added a commit that referenced this issue


          Issue #3162 - Use Jetty specific Servlet API jar.

8ff8242

Removed references to jetty-osgi-servlet-api.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>

joakime added a commit that referenced this issue


          Issue #3162 - Correcting websocket issues in OSGi

c3348a0

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>

joakime added a commit that referenced this issue


          Issue #3162 - Fixing OSGi manifest for websocket

85f74f1

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>

joakime added a commit that referenced this issue


          Issue #3162 - correcting typo

e0f4e5a

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>

joakime added a commit that referenced this issue


          Issue #3162 - correcting logger name

e16e3f1

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>

joakime added a commit that referenced this issue


          Issue #3162 - Adding missing Configuration reference

7f6add5

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>

joakime added a commit that referenced this issue


          Issue #3162 - Updating XML (removing references that seem to be getti…

db11be0

…ng in the way)

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>

joakime added a commit that referenced this issue


          Issue #3162 - Correcting package name exposure (missing 's')

01e1f01

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>

joakime added a commit that referenced this issue


          Issue #3162 - Making dependents OSGi aware

231892e

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>

joakime added a commit that referenced this issue


          Issue #3162 - Introducing more convenience Options for PaxExam

24e680e

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>

joakime added a commit that referenced this issue


          Issue #3162 - Fail test early if conscrypt-version is undefined (li…

97bba2e

…ke on Windows, or within an IDE)

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>

joakime added a commit that referenced this issue


          Issue #3162 - Fixing testcase assertions

7262bfd

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>

joakime added a commit that referenced this issue


          Issue #3162 - Attempting to address ServiceLoader with javax.websocke…

435dd20

…t (client) on OSGi

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>

janbartel added a commit that referenced this issue


          Issue #3162 Partial fix for javaxwebsocket in osgi, wip.

1167adf

gregw pushed a commit that referenced this issue


          Issue #3162 - Attempting to address ServiceLoader with javax.websocke…

ff0aa96

…t (client) on OSGi

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>

gregw pushed a commit that referenced this issue


          Issue #3162 Partial fix for javaxwebsocket in osgi, wip.

gregw mentioned this issue

Use jetty specific websocket API jar #3197

Closed

joakime added a commit that referenced this issue


          Issue #3162 - Using snapshot repositories on CI (temporary)

755d572

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>

joakime added a commit that referenced this issue


          Issue #3162 - Reverting not-relevant OSGi changes

26fa79a

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>

joakime added a commit that referenced this issue


          Issue #3162 - Reverting not-relevant JspConfig change.

c25cbf3

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>

sbordet added a commit that referenced this issue


          Issue #3162 - Use Jetty specific Servlet API jar.

0d89f29

* Updated module-info.java to reference the "jetty.servlet.api" module.
* Updated POMs to reference the o.e.j.toolchain:jetty-servlet-api artifact.
* Removed references to jetty-schemas.jar.
* Updated attribute "org.eclipse.jetty.server.webapp.ContainerIncludeJarPattern"
  to match the new Jetty Servlet API jar.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>

sbordet added a commit that referenced this issue


          Issue #3162 - Use Jetty specific Servlet API jar.

66f8259

Removed references to jetty-osgi-servlet-api.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>

sbordet pushed a commit that referenced this issue


          Issue #3162 - Correcting websocket issues in OSGi

95bc15f

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>

sbordet pushed a commit that referenced this issue


          Issue #3162 - Introducing more convenience Options for PaxExam

e135197

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>

sbordet pushed a commit that referenced this issue


          Issue #3162 - Reverting not-relevant OSGi changes

72ad748

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>

sbordet added a commit that referenced this issue


          Issue #3162 - Use Jetty specific Servlet API jar.

33f314e

Updated to jetty-servlet-api:4.0.1, based on javax.servlet 4.0.1.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>

sbordet added a commit that referenced this issue


          Issue #3162 - Use Jetty specific Servlet API jar.

107170a

Updated to jetty-servlet-api:4.0.2, based on jakarta.servlet 4.0.2.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>

joakime added a commit that referenced this issue


          Issue #3162 - Fixing compilation issues

b09f1de

joakime added a commit that referenced this issue


          Issue #3162 - Correcting javadoc

e4df1fe

sbordet added a commit that referenced this issue


          Issue #3162 - Use Jetty specific Servlet API jar.

9286cdc

Updated references to Servlet jar to "jetty-servlet-api".

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>

sbordet added a commit that referenced this issue


          Merge pull request #3168 from eclipse/jetty-10.0.x-3162_jetty_servlet…

e2506d4

…_api

Issue #3162 - Use Jetty specific Servlet API jar.

Contributor Author

sbordet commented Feb 7, 2019

Fixed, now using jetty-servlet-api-4.0.2 based on jakarta.servlet-api 4.0.2.

sbordet closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment