Merge pull request #5154 from eclipse/jetty-10.0.x-SurefireUpdateWebS…

…ocketFailure Fix WebSocketServerExamplesTest to work after maven surefire update
jetty · Aug 16, 2020 · 471a06d · 471a06d
2 parents 74a1638 + de1077c
commit 471a06d
Show file tree

Hide file tree

Showing 10 changed files with 14 additions and 8 deletions.
diff --git a/jetty-websocket/websocket-javax-server/pom.xml b/jetty-websocket/websocket-javax-server/pom.xml
@@ -51,7 +51,7 @@
         <artifactId>maven-surefire-plugin</artifactId>
         <configuration>
           <argLine>
-            @{argLine} ${jetty.surefire.argLine} --add-exports org.eclipse.jetty.websocket.javax.server/org.eclipse.jetty.websocket.javax.server.examples=org.eclipse.jetty.websocket.javax.common --add-reads org.eclipse.jetty.websocket.javax.server=org.eclipse.jetty.security --add-reads org.eclipse.jetty.websocket.javax.common=org.eclipse.jetty.websocket.javax.server
+            @{argLine} ${jetty.surefire.argLine} --add-reads org.eclipse.jetty.websocket.javax.server=org.eclipse.jetty.security --add-reads org.eclipse.jetty.websocket.javax.common=org.eclipse.jetty.websocket.javax.server
           </argLine>
         </configuration>
       </plugin>

diff --git a/.../examples/GetHttpSessionConfigurator.java → .../examples/GetHttpSessionConfigurator.java b/.../examples/GetHttpSessionConfigurator.java → .../examples/GetHttpSessionConfigurator.java
@@ -16,7 +16,7 @@
 // ========================================================================
 //
 
-package org.eclipse.jetty.websocket.javax.server.examples;
+package org.eclipse.jetty.websocket.javax.tests.server.examples;
 
 import javax.servlet.http.HttpSession;
 import javax.websocket.HandshakeResponse;

diff --git a/...server/examples/GetHttpSessionSocket.java → ...server/examples/GetHttpSessionSocket.java b/...server/examples/GetHttpSessionSocket.java → ...server/examples/GetHttpSessionSocket.java
@@ -16,7 +16,7 @@
 // ========================================================================
 //
 
-package org.eclipse.jetty.websocket.javax.server.examples;
+package org.eclipse.jetty.websocket.javax.tests.server.examples;
 
 import java.io.IOException;
 import javax.servlet.http.HttpSession;

diff --git a/...server/examples/MyAuthedConfigurator.java → ...server/examples/MyAuthedConfigurator.java b/...server/examples/MyAuthedConfigurator.java → ...server/examples/MyAuthedConfigurator.java
@@ -16,7 +16,7 @@
 // ========================================================================
 //
 
-package org.eclipse.jetty.websocket.javax.server.examples;
+package org.eclipse.jetty.websocket.javax.tests.server.examples;
 
 import java.security.Principal;
 import javax.websocket.HandshakeResponse;

diff --git a/...javax/server/examples/MyAuthedSocket.java → ...tests/server/examples/MyAuthedSocket.java b/...javax/server/examples/MyAuthedSocket.java → ...tests/server/examples/MyAuthedSocket.java
@@ -16,7 +16,7 @@
 // ========================================================================
 //
 
-package org.eclipse.jetty.websocket.javax.server.examples;
+package org.eclipse.jetty.websocket.javax.tests.server.examples;
 
 import javax.websocket.OnMessage;
 import javax.websocket.server.ServerEndpoint;

diff --git a/.../server/examples/StreamingEchoSocket.java → .../server/examples/StreamingEchoSocket.java b/.../server/examples/StreamingEchoSocket.java → .../server/examples/StreamingEchoSocket.java
@@ -16,7 +16,7 @@
 // ========================================================================
 //
 
-package org.eclipse.jetty.websocket.javax.server.examples;
+package org.eclipse.jetty.websocket.javax.tests.server.examples;
 
 import java.io.IOException;
 import java.io.Reader;

diff --git a/...examples/WebSocketServerExamplesTest.java → ...examples/WebSocketServerExamplesTest.java b/...examples/WebSocketServerExamplesTest.java → ...examples/WebSocketServerExamplesTest.java
@@ -16,7 +16,7 @@
 // ========================================================================
 //
 
-package org.eclipse.jetty.websocket.javax.server.examples;
+package org.eclipse.jetty.websocket.javax.tests.server.examples;
 
 import java.net.URI;
 import java.util.concurrent.ArrayBlockingQueue;

diff --git a/.../resources/jetty-websocket-httpclient.xml → .../resources/jetty-websocket-httpclient.xml b/.../resources/jetty-websocket-httpclient.xml → .../resources/jetty-websocket-httpclient.xml
diff --git a/...websocket/websocket-util/src/main/java/org/eclipse/jetty/websocket/util/InvokerUtils.java b/...websocket/websocket-util/src/main/java/org/eclipse/jetty/websocket/util/InvokerUtils.java
@@ -26,6 +26,9 @@
 import java.util.Arrays;
 import java.util.List;
 
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
 public class InvokerUtils
 {
     public static class Arg
@@ -135,6 +138,7 @@ public Arg getParamArg(Method method, Class<?> paramType, int idx)
     }
 
     public static final ParamIdentifier PARAM_IDENTITY = new ParamIdentity();
+    private static final Logger LOG = LoggerFactory.getLogger(InvokerUtils.class);
 
     /**
      * Bind optional arguments to provided method handle
@@ -425,6 +429,8 @@ private static MethodHandle mutatedInvoker(MethodHandles.Lookup lookup, Class<?>
         {
             if (!throwOnFailure)
             {
+                if (LOG.isDebugEnabled())
+                    LOG.debug("Unable to obtain MethodHandle for " + method, e);
                 return null;
             }
 

diff --git a/pom.xml b/pom.xml
@@ -44,7 +44,7 @@
     <jetty.surefire.argLine>-Dfile.encoding=UTF-8 -Duser.language=en -Duser.region=US -showversion -Xmx2g -Xms2g -Xlog:gc:stderr:time,level,tags</jetty.surefire.argLine>
 
     <!-- some maven plugins versions -->
-    <maven.surefire.version>3.0.0-M4</maven.surefire.version>
+    <maven.surefire.version>3.0.0-M5</maven.surefire.version>
     <maven.compiler.plugin.version>3.8.1</maven.compiler.plugin.version>
     <maven.dependency.plugin.version>3.1.2</maven.dependency.plugin.version>
     <maven.resources.plugin.version>3.2.0</maven.resources.plugin.version>