Fix WebSocketServerExamplesTest to work after maven surefire update #5154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts
deleted the
jetty-10.0.x-SurefireUpdateWebSocketFailure
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If these example classes are in the
org.eclipse.jetty.websocket.javax.serverJPMS module they need to be unconditionally exported forWebSocketServerExamplesTestto be able to use them. So to get the test to work I have moved these example classes towebsocket-javax-testsas it does not have a JPMS module.The JPMS command line options don't seem to let you export unconditionally. I tried using both
and
in the
maven-surefire-pluginargline forwebsocket-javax-serverbut neither of them work, the package needs be exported unconditionally.