connectionListener of AbstractHTTP2ServerConnectionFactory cause the low performance of concurrent connect of http2 #2828
Comments
ligzy
changed the title
|
Having said that, perhaps it is now the case that the component tree is more likely to be a mostly write data structure than a mostly read data structure?
Would it be worth replacing it with Perhaps a benchmark? @gregw thoughts? |
|
@sbordet I question the need of HTTP2Sessions to be managed objects. They are transient instances that may end their lifecycle at anytime with a message from the remote end. Thus they are highly unreliable targets for any JMX operation, as the object may cease to exist between the discovery of the managed attribute and any attempt to call it. Almost all the managed attributes on the object are never going to change from the values set by the factory that creates the session, so it's managed object should be sufficient to convey that information. So I would suggest that we stop adding the sessions directly to the component tree. Instead we can create a new object, perhaps called a Http2SessionContainer, to the component tree. This object would be Dumpable and would dump all its sessions when dumped (either directly or as part of a component tree dump). This object would be managed, so it could provide managed attributes to describe the collection in general, and if need be it could have methods that would allow the attributes of individual sessions to be queried/set. The object would of course have the most appropriate data structure to best support the most frequent operations: add & remove of sessions. This would mimic other similar setups in jetty - eg the SelectorManager and SessionManager objects are both in the component tree, but the many transient objects that they manager are not. However their collections are visible via dumps and JMX aggregate operations. |
|
Note also that a Http2SessionContainer could have a method to add a specific session as a bean, if it really needed to expose that particular sessions MBean.... but I am still dubious that is necessary. |
|
I got. It can't get better performance. only up to about 130,000 connections. if i comment all about
it can accept up to 500,000 and more.(memory left about 14g of total 64g) so In our case, server will prefer better performance, and maybe not managed through JMX, so there have some option to set the manage properties, |
|
@gregw yes,we prefer the high performance for the jetty http2 server is our gateway, Before comment: After comment(the speed is satisfied:) ) |
Signed-off-by: Greg Wilkins <gregw@webtide.com>
|
@ligzy I don't know exactly what you are trying to test here. Seems like a synthetic benchmark of "let's bomb the server with connect requests and see when it dies" that never happens in reality and so it will give you back a number that may not be of any use to you: from this number you will not be able to derive any capacity for your real system. Is there any difference between #2831 and the case where you commented out the field? In any case, here a few suggestions:
|
… low performance. Improved JMX for the HTTP2SessionContainer. Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
…on_listener_contention Fixes #2828 - AbstractHTTP2ServerConnectionFactory concurrent connect low performance.
… low performance. Fixed test failure. Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
|
Hi "qtp1620112330-1064" #1064 prio=5 os_prio=0 tid=0x00007f104c01d000 nid=0xcce52 waiting on condition [0x00007f0f478bd000] |
|
@ligzy I don't understand your last comment. Make sure you are using the latest version of Jetty - the stack trace shows you are on an old version. |
Hi,
Thanks for your project. and i like jetty very much.I am writing one http2 server based on Jetty 9.4.x
Now I got one question,i found that:
One server can accept and hold connections up to 460,000 connections in one connection server if clients make connections: 50000 by 50000 through several client pc.
But the server can only accept up to about 160000 connections if the clients connect server 'at the same time', for example: 5 client pc make 300000 connection at the same time.(through multi ip), The other connect client get an connect timeout exception . And i found the recv-q multi in the server jvm.
I dump the jvm stack and found this:
I read the source and found that:
the connectionListener object cause the lock.
and an comment it to test.
I got the better performance accept the connection more faster and more connection and have no timeout.
so ,how about remove the member connectionListener of AbstractHTTP2ServerConnectionFactory for more high performance? or other solution?
The text was updated successfully, but these errors were encountered: