Fixes #2828 - AbstractHTTP2ServerConnectionFactory concurrent connect low performance. #2831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… low performance. Now HTTP/2 sessions are not added to the Jetty component tree, but rather just held by HTTP2SessionContainer that is added to the Jetty container tree at startup. HTTP2SessionContainer uses a concurrent Set to hold HTTP/2 sessions to have good add/remove performance. Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
This was referenced Aug 19, 2018
gregw
reviewed
Aug 21, 2018
| addManaged((LifeCycle)((HTTP2Connection)connection).getSession()); | ||
| Session session = ((HTTP2Connection)connection).getSession(); | ||
| sessions.add(session); | ||
| LifeCycle.start(session); |
There was a problem hiding this comment.
if start throws an exception, will onClosed be called to remove it?
There was a problem hiding this comment.
Historically, if an exception was thrown from a Connection.Listener we let it unwind the stack, which I don't think it's ideal.
I think such listeners should be wrapped in try/catch, log the exception and continue.
So either we wrap, or we leave it as is. I'm for wrapping.
gregw
approved these changes
Aug 21, 2018
| @@ -245,18 +252,43 @@ protected ServerParser newServerParser(Connector connector, ServerParser.Listene | |||
| return new ServerParser(connector.getByteBufferPool(), listener, getMaxDynamicTableSize(), getHttpConfiguration().getRequestHeaderSize()); | |||
| } | |||
|
|
|||
| private class ConnectionListener implements Connection.Listener | |||
| private class HTTP2SessionContainer implements Connection.Listener, Dumpable | |||
There was a problem hiding this comment.
make this a ManagedObject and dump() a ManagedOperation, so we can dump just the sessions from JMX. Also make the size of the sessions collection a managed attribute.
There was a problem hiding this comment.
Good suggestions, will do.
… low performance. Improved JMX for the HTTP2SessionContainer. Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
sbordet
deleted the
jetty-9.4.x-2828-http2_connection_listener_contention
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now HTTP/2 sessions are not added to the Jetty component tree,
but rather just held by HTTP2SessionContainer that is added to
the Jetty container tree at startup.
HTTP2SessionContainer uses a concurrent Set to hold HTTP/2 sessions
to have good add/remove performance.
Signed-off-by: Simone Bordet simone.bordet@gmail.com