Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review javax-websocket-server tests #3165

Closed
gregw opened this issue Nov 29, 2018 · 2 comments
Closed

Review javax-websocket-server tests #3165

gregw opened this issue Nov 29, 2018 · 2 comments
Assignees
@lachlan-roberts
Labels
Test
Milestone
10.0.x

Comments

@gregw
Copy link
Contributor

gregw commented Nov 29, 2018

There is only a single unit test in javax-websocket-server, yet about 10 classes. I suspect most of those classes are not used. Please review and cleanup.
@joakime joakime added this to the 10.0.x milestone Nov 29, 2018
@joakime joakime changed the title Jetty-10 javax-websocket-server tests Review javax-websocket-server tests Nov 29, 2018
@joakime joakime added the Test label Nov 29, 2018
lachlan-roberts added a commit to lachlan-roberts/jetty.project that referenced this issue Jan 2, 2019
@lachlan-roberts
Issue jetty#3165 - Review javax-websocket-server tests
101c15d 
moved DummyServerContainer to an nested class in PathParamTest
removed some example classes

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
@lachlan-roberts lachlan-roberts mentioned this issue Jan 2, 2019
Closed
@lachlan-roberts
Copy link
Contributor

@gregw these unused classes are example classes which may be used in documentation and for debugging purposes

lachlan-roberts added a commit to lachlan-roberts/jetty.project that referenced this issue Feb 13, 2019
@lachlan-roberts
Issue jetty#3165 - Redesign on the WebSocketProxy
7abd622 
- Redesigned the proxy into a new class called WebSocketProxy containing
a Client2Proxy FrameHandler and a Server2Proxy FrameHandler

- WebSocketProxy uses synchronized blocks with an enum state instead
of the previous compare and sets

- Created a new test similar to ProxyFrameHandlerTest to test the new
WebSocketProxy

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts added a commit to lachlan-roberts/jetty.project that referenced this issue Feb 18, 2019
@lachlan-roberts
Issue jetty#3165 - rearrange packages for javax-websocket-server tests
8916e35 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts added a commit to lachlan-roberts/jetty.project that referenced this issue Feb 18, 2019
@lachlan-roberts
Issue jetty#3165 - added test for examples in javax-websocket-server
61c8f0d 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts added a commit to lachlan-roberts/jetty.project that referenced this issue Feb 18, 2019
@lachlan-roberts
Issue jetty#3165 - Configure the HttpClient via XmlHttpClientProvider
089854d 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
@lachlan-roberts lachlan-roberts mentioned this issue Feb 18, 2019
Merged
lachlan-roberts added a commit to lachlan-roberts/jetty.project that referenced this issue Feb 18, 2019
@lachlan-roberts
Issue jetty#3165 - Configure the HttpClient via XmlHttpClientProvider
b72f6c5 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts added a commit to lachlan-roberts/jetty.project that referenced this issue Feb 19, 2019
@lachlan-roberts
Issue jetty#3165 - rearrange packages for javax-websocket-server tests
beff8a2 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts added a commit to lachlan-roberts/jetty.project that referenced this issue Feb 19, 2019
@lachlan-roberts
Issue jetty#3165 - added test for examples in javax-websocket-server
1e93a46 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts added a commit to lachlan-roberts/jetty.project that referenced this issue Feb 19, 2019
@lachlan-roberts
Issue jetty#3165 - Configure the HttpClient via XmlHttpClientProvider
4378f5d 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts added a commit to lachlan-roberts/jetty.project that referenced this issue Feb 20, 2019
@lachlan-roberts
Issue jetty#3165 - fix to javax-websocket-server module issues
58c0808 
Signed-off-by: lachan-roberts <lachlan@webtide.com>
gregw added a commit that referenced this issue Feb 20, 2019
@gregw
Merge pull request #3366 from lachlan-roberts/jetty-10.0.x-3165-javax…
dcb1cc6 
…-websocket-server-tests

Issue #3165 - javax-websocket-server tests
lachlan-roberts added a commit to lachlan-roberts/jetty.project that referenced this issue Feb 22, 2019
@lachlan-roberts
Issue jetty#3165 use add-exports instead of add-opens in javax WS-Ser…
037d8b9 
…ver pom

Signed-off-by: lachan-roberts <lachlan@webtide.com>
@lachlan-roberts lachlan-roberts mentioned this issue Feb 22, 2019
Merged
sbordet added a commit that referenced this issue Feb 22, 2019
@sbordet
Merge pull request #3384 from lachlan-roberts/jetty-10.0.x-3165-javax…
3a7dee0 
…-websocket-server-tests

Issue #3165 use add-exports instead of add-opens in javax WS-Server pom
lachlan-roberts added a commit to lachlan-roberts/jetty.project that referenced this issue Mar 1, 2019
@lachlan-roberts
Issue jetty#3165 use add-exports instead of add-opens in javax WS-Ser…
55c1b5e 
…ver pom

Signed-off-by: lachan-roberts <lachlan@webtide.com>
@lachlan-roberts
Copy link
Contributor

There is now WebSocketServerExamplesTest which runs and tests all of the example classes. The remaining classes for JsrBrowserDebugTool are important for debugging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lachlan-roberts lachlan-roberts

Labels
Test
Projects
None yet
Milestone
10.0.x
Development

No branches or pull requests
3 participants
@gregw @joakime @lachlan-roberts