Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #3165 - javax-websocket-server tests #3366

Conversation

lachlan-roberts
Copy link
Contributor

@lachlan-roberts lachlan-roberts commented Feb 18, 2019

Issue #3165

Includes changes to the HttpClientProvider done in #3357 as these are waiting to be merged.

  • Moved all JsrBrowser classes into package org.eclipse.jetty.websocket.javax.server.browser
  • Moved Example Classes into package org.eclipse.jetty.websocket.javax.server.examples
  • Created WebSocketServerExamplesTest to run all the examples

@lachlan-roberts lachlan-roberts force-pushed the jetty-10.0.x-3165-javax-websocket-server-tests branch from 089854d to b72f6c5 Compare February 18, 2019 04:08
@sbordet
Copy link
Contributor

sbordet commented Feb 18, 2019

@lachlan-roberts #3357 has been merged, so A) please rebase this PR on top of jetty-10.0.x and B) fix the test failures.

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
@lachlan-roberts lachlan-roberts force-pushed the jetty-10.0.x-3165-javax-websocket-server-tests branch from b72f6c5 to 18a344e Compare February 19, 2019 01:40
@gregw
Copy link
Contributor

gregw commented Feb 20, 2019

@lachlan-roberts status?

Signed-off-by: lachan-roberts <lachlan@webtide.com>
@lachlan-roberts lachlan-roberts force-pushed the jetty-10.0.x-3165-javax-websocket-server-tests branch from 18a344e to 58c0808 Compare February 20, 2019 04:16
@lachlan-roberts
Copy link
Contributor Author

@gregw this should be fixed now, sorted out the issues with @olamy and @joakime

Copy link
Contributor

@gregw gregw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gregw gregw merged commit dcb1cc6 into jetty:jetty-10.0.x Feb 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants