Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autobahn WebSocketServer failures in jetty 10 #3216

Closed
lachlan-roberts opened this issue Dec 20, 2018 · 6 comments
Closed

Autobahn WebSocketServer failures in jetty 10 #3216

lachlan-roberts opened this issue Dec 20, 2018 · 6 comments
Labels
Test

Comments

@lachlan-roberts
Copy link
Contributor

lachlan-roberts commented Dec 20, 2018 •
edited
Loading

fix existing Autobahn WebSocketServer failures in jetty 10
@olamy
Copy link
Member

olamy commented Dec 20, 2018 •
edited
Loading

@lachlan-roberts fyi currently autobahn is in branch jetty-10.0.x_autobahn_test_ci
to run the tests: mvn clean install -pl :test-websocket-autobahn -am -e -DskipTests -Pautobahn
or use 'Build Now' here https://jenkins.webtide.net/job/nightlies/job/jetty-10.0.x-autobahn/

@lachlan-roberts
Copy link
Contributor Author

@olamy I was getting some failures of the autobahn tests locally and I made some changes to fix them however the failures in https://jenkins.webtide.net/job/nightlies/job/jetty-10.0.x-autobahn/ look different to the ones I was getting

lachlan-roberts added a commit to lachlan-roberts/jetty.project that referenced this issue Dec 20, 2018
@lachlan-roberts
Issue jetty#3216 - Autobahn WebSocketServer failures in jetty 10
164859f 
removed maxFrameSize from CompressExtension now use the
WebSocketChannel.getMaxFrameSize() to fix a bug where a change in the
WebSocketChanel maxFrameSize was not reaching the CompressExtension

create dummy WebSocketChannel in tests using CompressExtension without
a channel to replace the setter for maxFrameSize

increased the maxFrameSize in AutobahnWebSocketNegotiator to fix
autobahn tests being over maxFrameSize after being inflated

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
@olamy
Copy link
Member

olamy commented Dec 20, 2018

ok I have created both #3218 and #3217 so autobahn run will be available in 9.4.x and 10.0.x
how do run the suite locally?

@olamy olamy added the Test label Dec 20, 2018
@olamy
Copy link
Member

olamy commented Dec 20, 2018

related to #3166

@lachlan-roberts
Copy link
Contributor Author

lachlan-roberts commented Dec 20, 2018 •
edited
Loading

there are instructions how to install and run it in the javadoc of the AutobahnWebSocketServer

i just run the AutobahnWebSocketServer through the IDE then run the command
wstest --mode=fuzzingclient --spec=fuzzingclient.json from command line

https://github.com/eclipse/jetty.project/blob/a5e89d03409bb3563838ea302b4e26be9fc925f5/jetty-websocket/websocket-core/src/test/java/org/eclipse/jetty/websocket/core/autobahn/AutobahnWebSocketServer.java#L33-L64

@olamy
Copy link
Member

olamy commented Dec 20, 2018

ah ok I didn't know this AutobahnWebSocketServer.java I have to update both branches to use that :)

@lachlan-roberts lachlan-roberts mentioned this issue Dec 22, 2018
Merged
gregw added a commit that referenced this issue Dec 23, 2018
@gregw
Merge pull request #3224 from lachlan-roberts/jetty-10.0.x-3216-Autob…
9216d5a 
…ahnWebSocketServerFailures

Issue #3216 - Autobahn WebSocketServer failures in jetty 10
@gregw gregw closed this as completed Dec 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Test
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@olamy @gregw @lachlan-roberts