Issue #3216 - Autobahn WebSocketServer failures in jetty 10 #3224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removed maxFrameSize from CompressExtension now use the WebSocketChannel.getMaxFrameSize() to fix a bug where a change in the WebSocketChanel maxFrameSize was not reaching the CompressExtension create dummy WebSocketChannel in tests using CompressExtension without a channel to replace the setter for maxFrameSize increased the maxFrameSize in AutobahnWebSocketNegotiator to fix autobahn tests being over maxFrameSize after being inflated Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts
deleted the
jetty-10.0.x-3216-AutobahnWebSocketServerFailures
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removed maxFrameSize from
CompressExtensionnow use theWebSocketChannel.getMaxFrameSize()to fix a bug where a change in theWebSocketChanelmaxFrameSize was not reaching theCompressExtensioncreate dummy
WebSocketChannelin all tests which were using aCompressExtensionwithouta channel, as the the extension now uses the channels maxFrameSize
increased the maxFrameSize in
AutobahnWebSocketNegotiatorto fixautobahn tests being over maxFrameSize after being inflated
#3216