Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add tests for unused websocket handler classes in jetty-10 #4771

Closed
lachlan-roberts opened this issue Apr 14, 2020 · 0 comments · Fixed by #4775
Closed

add tests for unused websocket handler classes in jetty-10 #4771

lachlan-roberts opened this issue Apr 14, 2020 · 0 comments · Fixed by #4775
Assignees
@lachlan-roberts
Labels
Test

Comments

@lachlan-roberts
Copy link
Contributor

Jetty version
10.0.x

Description
There are several classes in org.eclipse.jetty.websocket.javax.tests.handlers which are the different onMessage implementations, but most of them are completely unused. There should be a test to run these to test they actually work.
@lachlan-roberts lachlan-roberts self-assigned this Apr 14, 2020
@lachlan-roberts lachlan-roberts changed the title add tests to run unused websocket handler classes in jetty-10 add tests for unused websocket handler classes in jetty-10 Apr 14, 2020
lachlan-roberts added a commit that referenced this issue Apr 14, 2020
@lachlan-roberts
Issue #4771 - cleanup and add tests for the different ws message hand…
c7821f1 
…lers

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts added a commit that referenced this issue Apr 15, 2020
@lachlan-roberts
Issue #4771 - cleanup and add tests for the different ws message hand…
7bcfdfd 
…lers

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
@lachlan-roberts lachlan-roberts mentioned this issue Apr 15, 2020
Merged
lachlan-roberts added a commit that referenced this issue Apr 15, 2020
@lachlan-roberts
Issue #4771 - cleanup and add tests for the different ws message hand…
4047e31 
…lers

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
@joakime joakime linked a pull request Apr 15, 2020 that will close this issue
Issue #4771 - cleanup and add tests for the unused ws message handlers #4775
Merged
lachlan-roberts added a commit that referenced this issue Apr 19, 2020
@lachlan-roberts
Merge pull request #4775 from eclipse/jetty-10.0.x-4771-WebSocketMess…
f23236b 
…ageHandlerTests

Issue #4771 - cleanup and add tests for the unused ws message handlers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lachlan-roberts lachlan-roberts

Labels
Test
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #4771 - cleanup and add tests for the unused ws message handlers jetty/jetty.project
1 participant
@lachlan-roberts