Issue #4771 - cleanup and add tests for the unused ws message handlers #4775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lers Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts
force-pushed
the
jetty-10.0.x-4771-WebSocketMessageHandlerTests
branch
from
7bcfdfd
to
4047e31
Compare
gregw
approved these changes
Apr 18, 2020
lachlan-roberts
deleted the
jetty-10.0.x-4771-WebSocketMessageHandlerTests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #4771
I have added tests for the previously unused classes in
org.eclipse.jetty.websocket.javax.tests.handlersand I have added extra handlers to test all the cases more thoroughly. Similar tests have been introduced for the Jetty WS API tests.Some problems were found for some of the handlers when they do type checking of the MethodHandle for the MessageSink so that has now been fixed.