Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CompressionPools should use the new jetty-util Pool class #5287

Closed
lachlan-roberts opened this issue Sep 17, 2020 · 0 comments · Fixed by #5295
Closed

CompressionPools should use the new jetty-util Pool class #5287

lachlan-roberts opened this issue Sep 17, 2020 · 0 comments · Fixed by #5295
Assignees
@lachlan-roberts

Comments

@lachlan-roberts
Copy link
Contributor

Jetty version
10.0.x

Description
The new org.eclipse.jetty.util.Pool class is more efficient and we should try to implement CompressionPool using this.
@lachlan-roberts lachlan-roberts self-assigned this Sep 17, 2020
lachlan-roberts added a commit that referenced this issue Sep 17, 2020
@lachlan-roberts
Issue #5287 - rework CompressionPool to use the jetty-util pool
9c23d9f 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts added a commit that referenced this issue Sep 18, 2020
@lachlan-roberts
Issue #5287 - fix usages of new CompressionPool
ea59f22 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts added a commit that referenced this issue Sep 18, 2020
@lachlan-roberts
Issue #5287 - Pool the entries instead of just the Deflater/Inflaters
01fbd2d 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts added a commit that referenced this issue Sep 23, 2020
@lachlan-roberts
Issue #5287 - Changes from review & fix broken tests from NPE
ae4ed15 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts added a commit that referenced this issue Sep 23, 2020
@lachlan-roberts
Issue #5287 - remove IllegalArgumentException from CompressionPool Entry
4b54aca 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts added a commit that referenced this issue Sep 23, 2020
@lachlan-roberts
Issue #5287 - make default CompressionPool capacity 1024
61908b5 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts added a commit that referenced this issue Sep 25, 2020
@lachlan-roberts
Issue #5287 - close deflater on release if non-pooled entry
5861709 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts added a commit that referenced this issue Oct 2, 2020
@lachlan-roberts
Issue #5287 - share compression pools and size with max num threads
8325608 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts added a commit that referenced this issue Oct 14, 2020
@lachlan-roberts
Issue #5287 - rework CompressionPool to use the jetty-util pool
b239fa0 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts added a commit that referenced this issue Oct 14, 2020
@lachlan-roberts
Issue #5287 - fix usages of new CompressionPool
21576f2 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts added a commit that referenced this issue Oct 14, 2020
@lachlan-roberts
Issue #5287 - Pool the entries instead of just the Deflater/Inflaters
d241c66 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts added a commit that referenced this issue Oct 14, 2020
@lachlan-roberts
Issue #5287 - Changes from review & fix broken tests from NPE
5dc0242 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts added a commit that referenced this issue Oct 14, 2020
@lachlan-roberts
Issue #5287 - remove IllegalArgumentException from CompressionPool Entry
dd06008 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts added a commit that referenced this issue Oct 14, 2020
@lachlan-roberts
Issue #5287 - make default CompressionPool capacity 1024
608a895 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts added a commit that referenced this issue Oct 14, 2020
@lachlan-roberts
Issue #5287 - close deflater on release if non-pooled entry
7cac3d7 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts added a commit that referenced this issue Oct 14, 2020
@lachlan-roberts
Issue #5287 - share compression pools and size with max num threads
0e3cfe8 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts added a commit that referenced this issue Oct 16, 2020
@lachlan-roberts
Merge pull request #5295 from eclipse/jetty-10.0.x-5287-CompressionPool
c95fc2a 
Issue #5287 - rework CompressionPool to use the jetty-util pool
@lachlan-roberts lachlan-roberts linked a pull request Oct 21, 2020 that will close this issue
Issue #5287 - rework CompressionPool to use the jetty-util pool #5295
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lachlan-roberts lachlan-roberts

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #5287 - rework CompressionPool to use the jetty-util pool jetty/jetty.project
1 participant
@lachlan-roberts