Issue #5287 - rework CompressionPool to use the jetty-util pool #5295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregw
requested changes
Sep 18, 2020
jetty-util/src/main/java/org/eclipse/jetty/util/compression/CompressionPool.java
Show resolved
Hide resolved
jetty-util/src/main/java/org/eclipse/jetty/util/compression/CompressionPool.java
Outdated
Show resolved
Hide resolved
jetty-util/src/main/java/org/eclipse/jetty/util/compression/CompressionPool.java
Outdated
Show resolved
Hide resolved
...mmon/src/main/java/org/eclipse/jetty/websocket/core/internal/PerMessageDeflateExtension.java
Outdated
Show resolved
Hide resolved
tests/jetty-jmh/src/main/java/org/eclipse/jetty/server/jmh/DeflaterPoolBenchmark.java
Show resolved
Hide resolved
|
@gregw can I get a re-review |
gregw
requested changes
Oct 12, 2020
jetty-util/src/main/java/org/eclipse/jetty/util/compression/DeflaterPool.java
Outdated
Show resolved
Hide resolved
jetty-util/src/main/java/org/eclipse/jetty/util/compression/InflaterPool.java
Outdated
Show resolved
Hide resolved
...-server/src/main/java/org/eclipse/jetty/websocket/core/server/WebSocketServerComponents.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts
force-pushed
the
jetty-10.0.x-5287-CompressionPool
branch
from
bb1a4b6
to
4690aa5
Compare
gregw
approved these changes
Oct 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on PR #5248 which should be merged before this PR.