Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move jetty-http-tools under the project root #5401

Closed
sbordet opened this issue Oct 6, 2020 · 2 comments · Fixed by #5403
Closed

Move jetty-http-tools under the project root #5401

sbordet opened this issue Oct 6, 2020 · 2 comments · Fixed by #5403
Assignees
@joakime
Labels
Build Task

Comments

@sbordet
Copy link
Contributor

sbordet commented Oct 6, 2020

Jetty version
10.0.x

Description
HttpTester is a useful tool to test HTTP requests/responses.

In Jetty 9.4.x, this was available in jetty-http with the classifier tests.

In Jetty 10.0.x it's not deployed to Maven Central because it's under $JETTY_ROOT/tests/, but would be great if it is available again in Central for other projects such as CometD to use it.
@sbordet
Copy link
Contributor Author

sbordet commented Oct 6, 2020

Remember to add a module-info.java for it, likely just requires transitive org.eclipse.jetty.http.

@joakime joakime self-assigned this Oct 6, 2020
joakime added a commit that referenced this issue Oct 6, 2020
@joakime
Issue #5401 - Moving jetty-http-tools top level project.
ba48463 
+ Ensures that it will be deployed.
+ Adding to generated (aggregate-like) javadoc as well.

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
@joakime joakime linked a pull request Oct 6, 2020 that will close this issue
Issue #5401 - Moving jetty-http-tools top level project. #5402
Closed
@joakime
Copy link
Contributor

joakime commented Oct 6, 2020

Opened PR #5402

joakime added a commit that referenced this issue Oct 6, 2020
@joakime
Issue #5401 - Moving jetty-http-tools top level project.
a22c41e 
+ Updating jetty-http-tools dependencies, as it's no longer
  in the org.eclipse.jetty.tests groupId.

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
joakime added a commit that referenced this issue Oct 6, 2020
@joakime
Issue #5401 - Fixing test failure due to optional JPMS dep.
cf0c141 
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
joakime added a commit that referenced this issue Oct 7, 2020
@joakime
Issue #5401 - Eliminate org.eclipse.jetty.http.tools.matchers
628e7a4 
+ Moved far worse description-less test assertions.

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
joakime added a commit that referenced this issue Oct 7, 2020
@joakime
Issue #5401 - Move HttpTester to jetty-http
857e888 
+ leaving jetty-http-tools alone

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
@joakime joakime mentioned this issue Oct 7, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joakime joakime

Labels
Build Task
Projects
None yet
Milestone
No milestone
2 participants
@joakime @sbordet