Issue #5401 - Moving jetty-http-tools top level project. #5402
Conversation
+ Ensures that it will be deployed. + Adding to generated (aggregate-like) javadoc as well. Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
+ Updating jetty-http-tools dependencies, as it's no longer in the org.eclipse.jetty.tests groupId. Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
| requires transitive org.eclipse.jetty.http; | ||
|
|
||
| // Optional - only required if you use hamcrest too. | ||
| requires static org.hamcrest; |
There was a problem hiding this comment.
OMG. Just to support assertThat() now we need to depend on an automatic module.
Can we just get rid of the hamcrest dependency? It adds nothing and just complicates things -- everything is already available in the HttpFields API.
There was a problem hiding this comment.
I looked into that (getting rid of hamcrest in jetty-http-tools), but it made for a MUCH larger PR to change the existing code (in the rest of jetty) that uses these hamcrest features exposed in jetty-http-tools.
If you are gung-ho on this, I'll start work on removing it.
There was a problem hiding this comment.
Alright, will do.
I'll rebuild this PR from scratch with the jetty-http-tools split between top level and matchers still in /tests/
+ Moved far worse description-less test assertions. Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
|
Will rebuild in cleaner way. |
Signed-off-by: Joakim Erdfelt joakim.erdfelt@gmail.com