Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HttpInput may skip setting fill interest #5691

Closed
sbordet opened this issue Nov 20, 2020 · 0 comments · Fixed by #5692
Closed

HttpInput may skip setting fill interest #5691

sbordet opened this issue Nov 20, 2020 · 0 comments · Fixed by #5692
Assignees
@sbordet

Comments

@sbordet
Copy link
Contributor

sbordet commented Nov 20, 2020

Jetty version
10.0.x

Description
HttpInput.run() may try to get the next content, but if it is null it does not set fill interest.

This also happens in AsyncContentProducer.isReady().
@sbordet sbordet self-assigned this Nov 20, 2020
sbordet added a commit that referenced this issue Nov 20, 2020
@sbordet
Issue #5691 - HttpInput may skip setting fill interest.
8edb5cf 
Code cleanups and logging improvements.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
sbordet added a commit that referenced this issue Nov 20, 2020
@sbordet
Fixes #5691 - HttpInput may skip setting fill interest.
4654335 
HttpInput.run() now uses contentProvider.isReady() to ensure that
if there is no content, the fill interest is set.

AsyncContentProvider.isReady() is now looping if there is content
but it cannot be transformed (e.g. too few gzipped bytes).

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
@sbordet sbordet linked a pull request Nov 20, 2020 that will close this issue
HttpInput may skip setting fill interest #5692
Merged
sbordet added a commit that referenced this issue Nov 21, 2020
@sbordet
Fixes #5691 - HttpInput may skip setting fill interest.
1ac0af4 
Updates after review.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
@lorban lorban mentioned this issue Nov 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbordet sbordet

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

HttpInput may skip setting fill interest jetty/jetty.project
1 participant
@sbordet