Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-assess the state transitions done in AsyncContentProducer.isReady() #5704

Closed
lorban opened this issue Nov 23, 2020 · 0 comments · Fixed by #5710
Closed

Re-assess the state transitions done in AsyncContentProducer.isReady() #5704

lorban opened this issue Nov 23, 2020 · 0 comments · Fixed by #5710
Assignees
@lorban
Labels
Question

Comments

@lorban
Copy link
Contributor

lorban commented Nov 23, 2020

Jetty version
10.0

Question
Is the call to HttpChannelState.onContentAdded() in AsyncContentProducer.isReady() really necessary after the first if (content != null) check in case it resolves to true?

If it happens that this call is unneeded, the javadoc contract on ContentProducer.isReady() is then wrong as it explicitly says that the state MUST be UNREADY or READY after such call which would then be wrong as the state could also be IDLE then.

This question was raised in the context of #5691.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lorban lorban

Labels
Question
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove unnecessary transition to READY in ContentProducer.isReady jetty/jetty.project
1 participant
@lorban