Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unnecessary transition to READY in ContentProducer.isReady #5710

Merged
merged 1 commit into from
Nov 24, 2020

Conversation

lorban
Copy link
Contributor

@lorban lorban commented Nov 23, 2020

[closes #5704] It doesn't look necessary to transition to READY after a call to isReady.

Signed-off-by: Ludovic Orban <lorban@bitronix.be>
@lorban lorban force-pushed the jetty-10.0.x-5704-isReady-ChannelState branch from 8a9a240 to 2d46951 Compare November 23, 2020 15:25
@lorban lorban requested a review from gregw November 23, 2020 16:15
@lorban lorban marked this pull request as ready for review November 23, 2020 16:55
Copy link
Contributor

@gregw gregw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM... or at least it will when CI is happy

@lorban lorban merged commit c7444ff into jetty-10.0.x Nov 24, 2020
@lorban lorban deleted the jetty-10.0.x-5704-isReady-ChannelState branch November 24, 2020 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-assess the state transitions done in AsyncContentProducer.isReady()
3 participants