Issue #11911 Fix documentation example for Request.getHttpUri #11916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbordet
requested changes
Jun 13, 2024
| // Replaces: | ||
| // - servletRequest.getRequestURL(); | ||
| String fullRequestURI = request.getHttpURI().asString(); | ||
| StringBuffer requestURL = new StringBuffer(HttpURI.build(request.getHttpURI()).query(null).asString()); |
There was a problem hiding this comment.
I think splitting makes it more clear what is the Jetty API, and what is boilerplate:
Suggested change
| StringBuffer requestURL = new StringBuffer(HttpURI.build(request.getHttpURI()).query(null).asString()); | |
| HttpURI uri = HttpURI.build(request.getHttpURI()).query(null); | |
| StringBuffer requestURL = new StringBuffer(uri.asString()); |
sbordet
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11911
Migration documentation implies that
Request.getHttpURI()is the jetty-12 substitute forRequest.getRequestURL()in prior versions, which is not strictly true. Clarified the code example.