Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #11911 Fix documentation example for Request.getHttpUri #11916

Merged
merged 4 commits into from
Jun 14, 2024
Merged

Issue #11911 Fix documentation example for Request.getHttpUri #11916

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
92d1c24
Issue #11911 Fix documentation example for Request.getHttpUri
janbartel Jun 13, 2024
225b570
import httpuri
janbartel Jun 13, 2024
33c2453
split into 2 lines as per reviewer request
janbartel Jun 14, 2024
04e11db
Fix
janbartel Jun 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions ...ples/src/main/java/org/eclipse/jetty/docs/programming/migration/ServletToHandlerDocs.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
import org.eclipse.jetty.http.HttpFields;
import org.eclipse.jetty.http.HttpHeader;
import org.eclipse.jetty.http.HttpStatus;
import org.eclipse.jetty.http.HttpURI;
import org.eclipse.jetty.http.Trailers;
import org.eclipse.jetty.io.Content;
import org.eclipse.jetty.server.Context;
Expand Down Expand Up @@ -60,10 +61,11 @@ public boolean handle(Request request, Response response, Callback callback) thr
// - servletRequest.getProtocol();
String protocol = request.getConnectionMetaData().getProtocol();

// Gets the full request URI.
// Gets the request URL.
// Replaces:
// - servletRequest.getRequestURL();
String fullRequestURI = request.getHttpURI().asString();
HttpURI httpURI = HttpURI.build(request.getHttpURI()).query(null);
StringBuffer requestURL = new StringBuffer(httpURI.asString());

// Gets the request context.
// Replaces:
Expand Down
Loading