-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #6008 - Allow absolute paths to be provided in start.ini for request log directory. #6009
Issue #6008 - Allow absolute paths to be provided in start.ini for request log directory. #6009
Conversation
…quest log directory. Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lachlan-roberts I know this PR is just following other precedent. But it is SO ugly! I really don't want this pattern to spread through our code.
Surely there must be a way we can resolve jetty.requestlog.dir
against a base dir and work out if it is relative or absolute. Let's hangout about this.
…tra comments. Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
We have too many ways to configure the same thing, a path. (in this case, we have .. absolute, relative-complete, and relative-parent) If we only supported 2 modes (relative and absolute), AND if we started to expand properties found in XML attributes this could go from ... <Property name="jetty.requestlog.absoluteFilePath">
<Default>
<Property name="jetty.base" default="." />/<Property name="jetty.requestlog.filePath">
<Default><Property name="jetty.requestlog.dir" default="logs"/>/yyyy_mm_dd.request.log</Default>
</Property>
</Default>
</Property> to <Property name="jetty.requestlog.absoluteFilePath" default="${jetty.base}/${jetty.requestlog.relativeDir}/yyyy_mm_dd.request.log" /> |
@joakime we need to maintain support for the existing properties. If we change to your suggestion of <Property name="jetty.requestlog.absoluteFilePath" default="${jetty.base}/${jetty.requestlog.relativeDir}/yyyy_mm_dd.request.log" /> then we will break anyone using the existing properties |
Draft PR #6022 is an alternate way to accomplish this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lachlan-roberts let's hold this in favor of #6022.
PR #6022 has been merged. |
Closes #6008
Adds a new attribute in the .ini file called
jetty.requestlog.absoluteFilePath
.This can be configured to provide an absolute path for the requestlog directory without changing the xml.