-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #6021 - PoC for resolvePath within XmlConfiguration #6022
Issue #6021 - PoC for resolvePath within XmlConfiguration #6022
Conversation
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
This could easily be done with a new element, but after discussion with @sbordet i felt doing via a static method was the minimal to prove the concept out. This draft PoC looks like ... <Set name="keystorePath">
<Call name="resolvePath" class="org.eclipse.jetty.xml.XmlConfiguration">
<Arg><Property name="jetty.base"/></Arg>
<Arg><Property name="jetty.sslContext.keyStorePath" default="etc/keystore.p12"/></Arg>
</Call>
</Set> The XML element version could look like ... <Set name="keystorePath">
<Path base="${jetty.base}"><Property name="jetty.sslContext.keyStorePath" default="etc/keystore.p12"/></Path>
</Set> Where the attribute |
We could have used the |
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
This proposal works for absolute paths, relative paths, linux, windows, OSX, machine shares (aka |
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
jetty-deploy/src/main/config/modules/global-webapp-common.d/global-webapp-common.xml
Outdated
Show resolved
Hide resolved
...an-remote-query/src/main/config-template/etc/sessions/infinispan/infinispan-remote-query.xml
Outdated
Show resolved
Hide resolved
jetty-xml/src/main/java/org/eclipse/jetty/xml/XmlConfiguration.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
jetty-xml/src/main/java/org/eclipse/jetty/xml/XmlConfiguration.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
This is a proposal / draft PR for simplifying the whole management of paths within our XmlConfiguration.
Signed-off-by: Joakim Erdfelt joakim.erdfelt@gmail.com