Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix BitBucket CommitInfo Url #122

Merged
merged 3 commits into from
Oct 26, 2023
Merged

Fix BitBucket CommitInfo Url #122

merged 3 commits into from
Oct 26, 2023

Conversation

attiasas
Copy link
Contributor

@attiasas attiasas commented Oct 25, 2023 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • I used go fmt ./... for formatting the code before submitting the pull request.
  • This feature is included on all supported VCS providers - GitHub, Bitbucket cloud, Bitbucket server, GitLab and Azure Repos.
  • I added the relevant documentation for the new feature.

For BitBucket, return the actual URL of the commit instead of the rest API URL for this commit

@attiasas attiasas added the bug Something isn't working label Oct 25, 2023
@attiasas attiasas marked this pull request as draft October 25, 2023 15:36
@attiasas attiasas marked this pull request as ready for review October 26, 2023 09:28
@attiasas attiasas requested a review from yahavi October 26, 2023 09:29
yahavi
yahavi approved these changes Oct 26, 2023
View reviewed changes
Copy link
Member

@yahavi yahavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@attiasas attiasas merged commit 4b45c31 into jfrog:master Oct 26, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yahavi yahavi yahavi approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@attiasas @yahavi