Add "GetCommitsWithQueryOptions" new API. #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
orz25
reviewed
Jun 25, 2024
vcsclient/github_test.go
Outdated
| AuthorEmail: "vinci@github.com", | ||
| }, result[1]) | ||
|
|
||
| _, err = createBadGitHubClient(t).GetCommits(ctx, owner, repo1, "master") |
There was a problem hiding this comment.
I think you should ball here GetCommitsWithQueryOptions func and get an error
orz25
reviewed
Jun 26, 2024
orz25
reviewed
Jun 26, 2024
orz25
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go fmt ./...for formatting the code before submitting the pull request.Expand the existing GetCommit API by adding optional parameters such as pagination and since/until values.