-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update nodejs version to 20.10.0 #23980
Conversation
Tests are failing without been reported. |
At current state I don't think it will succeed. |
@mshima All tests pass. Do you think it's OK to merge? |
@mraible tests are not passing. |
@mshima Are you referring to that issue? Seems to be missing the cli tests |
@mshima Do you think the CI failures are caused by the Node upgrade? |
@mraible it's related to how node handles loaders (adds support to typescript and esm mocking). Loaders in node 18 and prior versions are considered experimental and are rc in node 20. Loaders in node 20 runs in a different thread. The mocking state should be kept in user thread, but the mocking logic is done at the loaders thread. We are using https://github.com/node-loaders/loaders/tree/main/workspaces/mock loader for mocking. It should be possible to rework esm mocking since is used in 2 files only. |
@mshima Will it be possible to provide Node 18 and Node 20 support, or should we make Node 20 the baseline? |
Support both. |
I'm gonna keep adding bug bounties until someone stops me. 😜 |
@mshima It seems now that the tests break now with details |
Yes, that's the error. |
Any updates that can help move this one along? |
I will try with vitest. |
I am doing some tests with vitest and is not a good alternative for the main generator. vitest uses vite pipeline which brings a big overhead over mocha. JDL tests takes ~7 seconds using mocha and ~32 seconds using vitest in a M1 processor. We may consider node:test as a mocha alternative in the future. |
There is a script to convert tests to vitest here. I will switch the mocking lib to quibble and required node 18.19.0 for tests. |
@DanielFran bounty for related PRs claimed https://opencollective.com/generator-jhipster/expenses/211709 |
@mshima approved |
Fix #23882
Please make sure the below checklist is followed for Pull Requests.
When you are still working on the PR, consider converting it to Draft (below reviewers) and adding
skip-ci
label, you can still see CI build result at your branch.