Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[internal] Use the quibble for dependency mock in tests #24579

Merged
merged 2 commits into from
Dec 16, 2023

Conversation

mshima
Copy link
Member

@mshima mshima commented Dec 15, 2023

  • node 18.19.0 backported dynamic loader register
    Use dynamic register and drop support for test using node < 18.19.0
  • bump node to 18.19.0
  • switch to quibble for dependencies mocking

related to #23980


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@github-actions github-actions bot added theme: cli theme: dependencies Pull requests that update a dependency file theme: CI builds labels Dec 15, 2023
@mshima mshima changed the title Use the quibble for dependency mock in tests [internal] Use the quibble for dependency mock in tests Dec 15, 2023
@DanielFran DanielFran merged commit ff4449c into jhipster:main Dec 16, 2023
51 checks passed
@mshima mshima deleted the node-20 branch December 16, 2023 00:37
@deepu105 deepu105 added this to the 8.2.0 milestone Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme: CI builds theme: cli theme: dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants