Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing documentation #6

Merged
merged 1 commit into from
Feb 25, 2016
Merged

add missing documentation #6

merged 1 commit into from
Feb 25, 2016

Conversation

jlandon
Copy link
Owner

@jlandon jlandon commented Feb 24, 2016

  • Removed orientedSize() method on UIScreen. It's only useful for pre-iOS 8 projects, and since this repo only supports iOS 8+, the method is no longer necessary.
  • The only remaining "undocumented" code is the Key generic type parameter on the Dictionary operators. The operators are documented, but there's currently an open issue on Jazzy for mistakenly marking generic type parameters as "undocumented."

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@hsoi
Copy link
Collaborator

hsoi commented Feb 24, 2016

Good changes all around. And good catch on the orientedSize() -- was meaningful in the old repo, but isn't in Alexandria since backwards compatibility isn't an issue right now.

Thanx for doing this!

👍

hsoi added a commit that referenced this pull request Feb 25, 2016
@hsoi hsoi merged commit 4ab0e34 into master Feb 25, 2016
@hsoi hsoi deleted the documentation branch February 25, 2016 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants