Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic types in functions required to be documented #429

Closed
nvzqz opened this issue Dec 20, 2015 · 8 comments
Closed

Generic types in functions required to be documented #429

nvzqz opened this issue Dec 20, 2015 · 8 comments
Assignees
Labels

Comments

@nvzqz
Copy link

nvzqz commented Dec 20, 2015

When working with generic type parameters in global functions, jazzy insists that they should be documented. However, there is no way to document it and thus it just shows up as "Undocumented".

equalsoperatordocumentation

@nvzqz nvzqz changed the title Generic Parameters in Functions Generic types in functions required to be documented Dec 21, 2015
@jpsim jpsim added the bug label Apr 6, 2016
@jpsim
Copy link
Collaborator

jpsim commented Apr 6, 2016

Sorry for the lack of comments here @nvzqz, could you please check against the latest version of jazzy (0.6.0), a few improvements were made in this area so I'd love to know if this is still an issue so we can decide if we should invest some time into fixing this.

@diliedevs
Copy link

I'm using jazzy 0.6.0, but am still getting undocumented for generic types like T. I don't know how to document that. Hoping for a fix soon! I don't like it when my code is not 100% documented.

@yarneo
Copy link

yarneo commented Oct 19, 2016

+1

@maddiemort
Copy link

Still getting this with jazzy 0.7.2.

@pigeondotdev
Copy link
Contributor

We'll need to investigate this further. Anyone interested in tackling this?

@SDGGiesbrecht
Copy link
Contributor

SDGGiesbrecht commented Dec 10, 2016

As of 0.7.3, this is still a problem.

The following is an update‐to‐date, specific and consice description:

Jazzy treats generic type parameters as undocumented symbols. This results in an incorrect (deceptively low) documentation coverage percentage being displayed.

The undocumented.json output contains entries of the form:

    {
      "file": "/Path/To/File.swift",
      "line": 7,
      "symbol": "function(_:).T",
      "symbol_kind": "source.lang.swift.decl.generic_type_param",
      "warning": "undocumented"
    },

Compare this source with [this output] the output of the following test.
[Edit: The above linked documentation will soon be regenerated with a forked version of Jazzy where the bug has been fixed. See subsequent comments.]

To test it yourself, simply run the following terminal commands:

git clone https://github.com/SDGGiesbrecht/SDGLogic
cd SDGLogic
swift package generate-xcodeproj
jazzy
open docs/index.html
open docs/undocumented.json
cd ..

Coverage should be 100% and undocumented.json should be empty.

@SDGGiesbrecht
Copy link
Contributor

I submitted a pull request with a fix.

Until it is accepted, you can clone my fork at https://github.com/SDGGiesbrecht/jazzy, checkout the fix-429-generic-types branch, build jazzy from source (Instruction are under “Development”) and run the modified version.

@pigeondotdev
Copy link
Contributor

Awesome, thanks for filing the PR. I'll get someone to look at it stat. :)

@jpsim jpsim closed this as completed in 38eb48e Dec 13, 2016
jpsim added a commit that referenced this issue Dec 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants