Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Divide By Zero Error #248

Closed
jlewi opened this issue Sep 18, 2024 · 0 comments · Fixed by #252
Closed

Divide By Zero Error #248

jlewi opened this issue Sep 18, 2024 · 0 comments · Fixed by #252

Comments

@jlewi
Copy link
Owner

jlewi commented Sep 18, 2024

We're getting a panic here

foyle/app/pkg/learn/in_memory.go

Line 217 in 5f30c46

db.embeddings = mat.NewDense(int(float32(len(matches))/1.5), oai.SmallEmbeddingsDims, nil)

I think the problem is if len(matches) < 1.5 we end up rounding down to 0 which causes a problem.
@jlewi jlewi mentioned this issue Sep 20, 2024
Closed
jlewi added a commit that referenced this issue Sep 20, 2024
@jlewi
Ensure embeddings matrix is never initialized with zero dimensions
b1f1886 
* Because we divide by 1.5; in the edge case were we have 1 example we'd
  end up rounding down to 0 which will cause problems when we try to initialize a matrix to that size.
Fix #248
@jlewi jlewi mentioned this issue Sep 20, 2024
Merged
@jlewi jlewi closed this as completed in 95ffab7 Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ensure embeddings matrix is never initialized with zero dimensions jlewi/foyle
1 participant
@jlewi