Ensure embeddings matrix is never initialized with zero dimensions #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
jlewi
commented
Sep 20, 2024
jlewi
commented
- Because we divide by 1.5; in the edge case were we have 1 example we'd end up rounding down to 0 which will cause problems when we try to initialize a matrix to that size. Fix Divide By Zero Error #248
* Because we divide by 1.5; in the edge case were we have 1 example we'd end up rounding down to 0 which will cause problems when we try to initialize a matrix to that size. Fix #248
✅ Deploy Preview for foyle canceled.
|
jlewi
added a commit
that referenced
this pull request
Sep 26, 2024
When learner is initialized at program startup we want to initialize an empty array because learned examples might arrive during program execution. If we have a nil matrix to store them we will get a segfault. Ensuring a matrix is always initialized at startup is one way to solve this. Follow up to #252
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.