Evaluation needs to include the SelectedIndex in the GenerateCellsRequest #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uest * In #271 we added a SelectedIndex field to the GenerateCellsRequest to specify which cell in the notebook is active. * If we don't set it then it ends up defaulting to 0. In which case we end up truncating the notebook to just the first cell and then the evaluation results end up being all wrong.
jlewi
changed the title
✅ Deploy Preview for foyle canceled.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Properly handle completions in middle of document - Include LLM reque… #271 we added a SelectedIndex field to the GenerateCellsRequest to specify which cell in the notebook is active.
If we don't set it then it ends up defaulting to 0. In which case we end up truncating the notebook to just the first cell and then the evaluation results end up being all wrong.
Fix a bug in the evaluator runGenerate; if Agent.GenerateCells returns an error we need to abort execution of runGenerate otherwise we get a panic later in runGenerate when we try to access the message in the response.