Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Evaluation needs to include the SelectedIndex in the GenerateCellsRequest #275

Merged
merged 4 commits into from
Oct 5, 2024
Merged

Evaluation needs to include the SelectedIndex in the GenerateCellsRequest #275

merged 4 commits into from
Oct 5, 2024

Commits on Oct 4, 2024

  1. Evaluation needs to include the SelectedIndex in the GenerateCellsReq… 

    …uest

* In #271 we added a SelectedIndex field to the GenerateCellsRequest to
  specify which cell in the notebook is active.

* If we don't set it then it ends up defaulting to 0. In which case
  we end up truncating the notebook to just the first cell and then
  the evaluation results end up being all wrong.
    @jlewi
    jlewi committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    4951697 View commit details
    Browse the repository at this point in the history

  2. Fix segfault in evaluator.

    @jlewi
    jlewi committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    76556a0 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2024

  1. Add a comment.

    @jlewi
    jlewi committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    e769e0d View commit details
    Browse the repository at this point in the history

  2. Fix lint.

    @jlewi
    jlewi committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    3634f72 View commit details
    Browse the repository at this point in the history