Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GitHup githubv4 rather than cli/cli #4

Open
jlewi opened this issue Nov 20, 2022 · 0 comments
Open

Use GitHup githubv4 rather than cli/cli #4

jlewi opened this issue Nov 20, 2022 · 0 comments

Comments

@jlewi
Copy link
Owner

jlewi commented Nov 20, 2022

RepoHelper currently depends on code imported from GitHub's GoCLI
https://github.com/jlewi/hydros/blob/main/pkg/github/prs.go#L27

Migrage to github.com/shurcooL/githubv4. It is inspired by the higher level API in GitHub's GoLang CLI. A lot of the code is modified from that.
We don't use the CLI The CLI authors suggested (cli/cli#1327) that it would be better to use the API client libraries directly; github.com/shurcooL/githubv4. The CLI API is providing higher level functions ontop of the
underlying GraphQL API; it seems silly to redo that rather than just import it and reuse it.
https://github.com/cli/cli/blob/4d28c791921621550f19a4c6bcc13778a7525025/api/queries_pr.go

In particular we use
CreatePullRequest

And api.RepoLabels

jlewi pushed a commit that referenced this issue Nov 28, 2022
# This is the 1st commit message:

hydros automatically committing all files before running a sync
# This is the commit message #2:

hydros automatically committing all files before running a sync
# This is the commit message #3:

hydros automatically committing all files before running a sync
# This is the commit message #4:

hydros automatically committing all files before running a sync
# This is the commit message #5:

Remove binary

# This is the commit message #6:

hydros automatically committing all files before running a sync
# This is the commit message #7:

hydros automatically committing all files before running a sync
# This is the commit message #8:

Fix ssh key.

# This is the commit message #9:

Delete .idea

# This is the commit message #10:

hydros automatically committing all files before running a sync
# This is the commit message #11:

Revert "hydros automatically committing all files before running a sync"

This reverts commit e20ecba.

# This is the commit message #12:

hydros automatically committing all files before running a sync
# This is the commit message #13:

hydros automatically committing all files before running a sync
# This is the commit message #14:

hydros automatically committing all files before running a sync.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant