Support loading GitHub secrets from GCPSecretManager #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Support loading GihubApp private keys (and other secrets) from GCPSecret Manager * Create the files package which defines a FileHelper interface which can be supported across different file systems * This is based on https://github.com/kubeflow/internal-acls/blob/master/google_groups/pkg/gcp/gcs/filehelper.go * Add an implementation for GCPSecretManager and for LocalFileHelper * There is a GCS implementation we should copy later from https://github.com/kubeflow/internal-acls/blob/master/google_groups/pkg/gcp/gcs/filehelper.go * Refactor the GitHub transport manager to take the data of the private key rather than the private key file * This will enable us to load the key from different storage systems such as GCP Secret Manager.
jlewi
pushed a commit
that referenced
this pull request
Nov 28, 2022
# This is the 1st commit message: hydros automatically committing all files before running a sync # This is the commit message #2: hydros automatically committing all files before running a sync # This is the commit message #3: hydros automatically committing all files before running a sync # This is the commit message #4: hydros automatically committing all files before running a sync # This is the commit message #5: Remove binary # This is the commit message #6: hydros automatically committing all files before running a sync # This is the commit message #7: hydros automatically committing all files before running a sync # This is the commit message #8: Fix ssh key. # This is the commit message #9: Delete .idea # This is the commit message #10: hydros automatically committing all files before running a sync # This is the commit message #11: Revert "hydros automatically committing all files before running a sync" This reverts commit e20ecba. # This is the commit message #12: hydros automatically committing all files before running a sync # This is the commit message #13: hydros automatically committing all files before running a sync # This is the commit message #14: hydros automatically committing all files before running a sync.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support loading GihubApp private keys (and other secrets) from GCPSecret Manager
Create the files package which defines a FileHelper interface which can be supported across different file systems
Add an implementation for GCPSecretManager and for LocalFileHelper
Refactor the GitHub transport manager to take the data of the private key rather than the private key file
Upgrade to go 1.19 to address some dependency issues