Interim crate #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
with agl/ed25519/extra25519, the kleshni C implementation, and rfc9380.
Edwards rfc9380 tests and elligator representative randomness using tweaks.
remove extra rand byte read when elligator2 is disbled add a better (failing) subgroup test print result to see why failing test running but failing - scalar_base_mult_dirty or repr_from_pubkey probably incorrect somehow commit tests split out into their own files for organization elligator 2 using repres_from_pubkey working, some tests still failing mul_base_clamped_dirty working, tests also working - cleanup still needed interim crate branch progress commit. make mul_base_clamped_dirty public because that is how you get the correct pub make tests pass for 32 bit targets getting close, legacy not working working on docs and cleanup legacy moved to its own testcase so it is validated without exposing comments in the legacy test module docs crate docs and github actions add elligator equivalents of more github actions workflows working with workflows apply the FieldElement gt impl to fiat backends fixing negations for fiat and gt impl lint err format linting -_- more linting simplify wokflow to test only elligator2 more lints and formatting
jmwample
force-pushed
the
interim-crate
branch
2 times, most recently
from
676d572
to
4483c68
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets up to publish my own independent
curve25519crate in order to make the elligator2 implementation usable without requiring that the PR on dalek-crypto be completely merged. If / When the elligator2 PR is merged this crate will likely be yanked.This is useful as the implementation of elligator2 is functionally working and thoroughly tested, but the interface and integration into the
curve25519-daleklibrary may need iterations.