This repository has been archived by the owner on Apr 20, 2023. It is now read-only.
feat: add darwinForceDarkModeSupport option to support mojave dark mode for older electron versions #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…de for older electron versions
MarshallOfSound
changed the title
MarshallOfSound
force-pushed
the
mojave-dark-mode
branch
from
18f852b to
c75cf46
Compare
|
Test failures are due to GitHub API rate limit issues on Travis CI |
joaomoreno
approved these changes
Oct 1, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will add the
NSRequiresAquaSystemAppearance=falsekey value pair to the app'sInfo.plistto force dark mode support on Mojave.cc @bpasero
refs: microsoft/vscode#59742