-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable mojave dark mode support #59742
feat: enable mojave dark mode support #59742
Conversation
…uilt on the 10.14 SDK
@MarshallOfSound thanks. you can use this build (Electron 3.0.x included) to try it out: https://az764295.vo.msecnd.net/exploration/1e9d10654dfff127230af65393f0d3cd285ed2e4/VSCode-darwin-exploration.zip |
@bpasero Works perfectly 👍 |
When can we get this Mojave Dark Mode support for VS Code? |
@bpasero Is this expected out soon for VS Code? Dark Mode is so nice on the eyes |
Is it fixed in insider builds? I still have the problem (even if macOS hasn't dark mode enabled, I see a gray line on top of VSCode). |
@bpasero unfortunately it doesn't fix the problem: |
@warpdesign those builds are old, you should get an update and then its fine |
Electron is not built on the 10.14 SDK so we need to set a special
Info.plist
key to tell macOS we support dark mode.Closes #59421
Closes #59283
Closes #54838 (maybe, the line looks a little different but I think it's how mojave dark mode windows look)
Blocked by: joaomoreno/gulp-atom-electron#51