Refine ignore terminal. #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
my test nvim version infomations : nvim --version |
johnfrankmorgan
requested changes
Aug 8, 2024
|
Thanks for the PR @Waitzz, I've left a few comments. Let me know what you think. |
|
I have modified it according to your suggestion, please review it again, thank you ~ |
reproduction steps: 1. type :e to edit a lua file or other file not be ignored 2. type :terminal to open a terminal buffer 3. type :e to previous lua file or other file not be ignored 4. wrong highlight happened Change-Id: Ib96951e47f16f75cd7a7a7a84f1a9125e6a20c1e
johnfrankmorgan
approved these changes
Aug 18, 2024
|
Thanks @Waitzz! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a error highlight on terminal, reproduction steps :
terminal buffer will not set fietype so the "FileType" autocmd will not be excuted , I add a "TermOpen" autocmd to clean match if "ignore_terminal" is set to true, add clean function for user can clean match if they want. and I think we should need put any conditions in hightlignt function , they should be put in function who call them.
please confirm for me , best wishes.