Branch check #20
Closed
Branch check #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SceneAlgo : Add `optionHistory()`
We can't assume that if `dropSignal()` is emitted it was because _we_ accepted `dragEnterSignal()`. Another slot connected to `dragEnterSignal()` may have accepted it instead, in which case we don't want to do anything in our `GraphEditor.__drop`, on the assumption that another connection to `dropSignal()` will be dealing with it.
It's pretty clear from 6d8060c that this keypress handling was only intended to apply to NodeEditors, but it was instead being applied to all Editors, which would lead to errors like this in the GraphEditor : ``` ERROR : EventSignalCombiner : Traceback (most recent call last): File "/home/john/dev/build/gaffer-1.3/python/GafferSceneUI/SceneHistoryUI.py", line 237, in __nodeEditorKeyPress __editSourceNode( context, scene, selectedPath, nodeEditor ) File "/home/john/dev/build/gaffer-1.3/python/GafferSceneUI/SceneHistoryUI.py", line 128, in __editSourceNode nodeEditor.setNodeSet( Gaffer.StandardSet( [ node ] ) ) AttributeError: 'GraphEditor' object has no attribute 'setNodeSet' ```
SceneHistoryUI : Fix errors handling `Alt+E` on unexpected editors
GraphEditor : Create SceneReader, ImageReader or Reference nodes from file drag & drop
CI : Update to Cortex 10.5.4.2
…loatPlug` This addresses the problem raised in https://groups.google.com/g/gaffer-dev/c/9Ba1eaG1oeg, where AttributeQuery is failing to query a DoubleData attribute.
Until now, we were assuming that the plugs passed to `canSetValueOrAddKey()` did not have inputs, because we had already called `spreadsheetAwareSource()` to find the source plug. But that operates on V3fPlugs, and is blind to individual connections to each XYZ component (recall that the parent plug only has an input connection if all the children have connections from the children of another parent). This meant that if you promoted just one component to a box, or promoted several components individually, the transform handles would be disabled. The solution is to call `source()` one more time to find the plug we actually want to edit. At one point, I thought that `canSetValueOrAddKey()` was destined for more general usage, possibly in PlugAlgo. But the function in its new form isn't suitable for that at all, as it is tailored to the specifics of TransformTool operation. It would have been possible to keep it in its "pure" form, but only at the expense of duplicating the new checks into each of the derived classes.
For instance, if every component had a connection from the same promoted `uniformScale` plug. The problem here was that we were calling `setValueOrAddKey()` for all the components, even the ones not affected by the individual handle being dragged. Since each component is driven by the same plug, we'd be setting that plug three times, and only the Z component would win because it was set last. But if the Z component wasn't affected by the current handle, it would be setting the scale back to its _original_ value. We now consider the plugs that are affected by the current handle to avoid this clobbering. In the `uniformScale` case this has the expected effect - no matter which handle you pick, you get uniform scaling.
…rsions PlugAlgo : Convert all numeric types for `BoolPlug`, `IntPlug` and `FloatPlug`
The SetEditor one in particular was misleading, and both benefit from spelling out the important thread-safety reason for taking a static copy of the context.
…textComments HierarchyView, SetEditor : Improve comments surrounding context copies
TransformTool : Fix corner cases involving connection to individual XYZ components
Should have done this in the PR itself.
Delight MeshAlgo : Convert subdivision corners and creases
This is in order to define header and cell tooltips, maybe in the future we'll be able to do this directly for header tooltips via StandardPathColumn.
…ionFilter SetEditor : Display and filter by selected set members
By setting the child to `None` and _then_ hiding the frame, we were causing Qt to do two lots of layouting, one with an empty frame and one with nothing. This could cause "jiggle" when switching between tools in the Viewer. In an ideal world Qt would batch up these layout operations and do them once with no redraw in between. In fact I don't really know why it doesn't. As far as I know, it needs to return to the event loop to perform them, and I don't see where or how that's happening. But in lieu of real understanding, this is a simple and logical enough fix that removes a nasty visual annoyance.
…ache CI : Increase Windows SCons cache
LazyMethod : Fix running idle callback without a valid Qt Widget
As of today, actions are now run on Node20 by default, but this requires glibc >=2.28 so actions no longer run in our CentOS 7 build container. Setting `ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true` allows us to continue using Node16 for the near future, but support for this may be removed in October... https://github.blog/changelog/2024-05-17-updated-dates-for-actions-runner-using-node20-instead-of-node16-by-default/
CI : Continue using Node16 for actions
…eateIfMissingIconFix HistoryWindow : Add icon for `CreateIfMissing` tweak mode
There were two problems here : - We weren't checking that the attribute was an array. - When the attribute wasn't the right type, we were still setting the `singlePartMultiView` variable instead of ignoring the metadata as claimed. This later lead to an uninitialised read because `viewNames` was empty.
…ound ImageReader : Fix handling of invalid EXR `multiView` attributes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generally describe what this PR will do, and why it is needed
Related issues
Dependencies
Breaking changes
Checklist