feat: import wallet

[theborakompanioni]

Closes #137.

Adds the ability to import an existing wallet in Jam.

• Customize options (plain input of gaplimit and blockheight)
• Reset gaplimit to original value
• Add "back" button
• Prevent importing if rescan is active
• Call /display after rescanning finished
• Test on mainnet

How to test

After checking out the branch, execute npm run regtest:rebuild in order to rebuild your dev environment to get the lastest upstream changes from JM (the "import wallet" endpoint is only on master and not released yet). Otherwise you will get "Error while importing the wallet. Reason: Method Not Allowed" when trying to import a wallet.

[theborakompanioni]

Hey @editwentyone

This is now functional and can be tested.

Please note, that you have to run npm run regtest:rebuild if you have not done so since JoinMarket-Org/joinmarket-clientserver#1525 has be merged.

From my point of view the only thing that is missing the the blockheight-as-date-picker component (Currently, it is a normal number input). If that is okay with you, I'll tackle this in a follow-up PR.

What is still missing but needed before merging:

• Show options only with jm backenv version 0.9.10 (or 0.9.10dev) or greater
• Call /display after rescanning finished
• Improve or hide "rescan" page
• Test on mainnet

Also, this has not been tested on mainnet yet.

Any feedback to the current state would be highly appreciated 🙏

[theborakompanioni]

Follow-up PRs for stuff noticed during development:

• blockheight-as-date-picker component in Import Details Form
• Improve balance view (frozen + locked) (feat(balance): display frozen balance on jars #635)
• Refactor: Consistently use walletName or/and walletFileName
• Feat: Validate mnemonic phrase (display a warning if a word is not contained in BIP39, but let user submit the form)
• Feat: Check for existing wallet before importing/creating wallets (bug: Check for existing wallet before importing/creating wallets #636)

[theborakompanioni]

Rebased on master.

This is now "complete" and is ready for review.
Suggestions for wording/phrases improvements (in translation file) would be highly appreciated. But of course, the proper functioning of the new feature should be the main focus. 🙏

I will create issues for following related tasks which will be done in follow-up PRs:

• Show options only with jm backend version 0.9.10 (or 0.9.10dev) or greater (feat: ability to enable/disable features based on backend version #637)
• Input custom rescan blockheight as year/month datepicker (ui(import): Input custom rescan blockheight as year/month datepicker #638)

As well as for additional tasks that came up during development:

• Feat: Validate mnemonic phrase (feat(import): validate mnemonic phrase against BIP39 wordlist #641)
• Refactor: Consistently use walletName or/and walletFileName (refactor: Consistent use of walletName vs walletFileName #640)
• Refactor: use reloadWalletInfo from App component consistently
• Refactor: use button size "lg" consistently (ui(style): consistent button styling #639)

Addendum: Test on mainnet is not yet done and still to be performed.

[climardo]

👏 congrats. ive been following this pr since i had to do this manually and ive been looking forward to this. going to try and run this to give feedback (im a newb)

[theborakompanioni]

👏 congrats. ive been following this pr since i had to do this manually and ive been looking forward to this. going to try and run this to give feedback (im a newb)

This is so nice. ANY feedback is highly welcome! You can start with setting up the regtest environment. If you need any help or assistance, just ping me! 🙏

Edit: Sorry that it has taken so long to implement this basic feature.. 😬

[theborakompanioni]

Rebased on master (7a6b920)

[theborakompanioni]

Rebased on master (7a6b920)

Rebased again on current master (4d0479e)

[editwentyone]

cACK, on testnet, not main net

[theborakompanioni]

With help of some users, this has been tested on mainnet with a moderately used wallets. Rescanning from block 481824 (segwit activation) took around ~8 hours on average (on a raspberry). Wallet has been successfully imported. However, tests were always done on the Bitcoin Core instance, that was already aware of the wallet. It should work on pristine Bitcoin Core instances as well, but we have to wait for feedback to verify.