ui: blur Send form if service is running #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theborakompanioni
added
the
UI/UX
theborakompanioni
force-pushed
the
blur-send-page-if-service-is-running
branch
from
65e06f5 to
5cf4757
Compare
ghost
approved these changes
Jun 2, 2022
There was a problem hiding this comment.
See my comment over at #300 for why I think it makes sense to merge this now. Let me know if you strongly disagree @editwentyone. We can always revert this and discuss here. 🙏
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggestions by @dnlggr : #300 (comment)
If the whole form should be blurred, apply the PR, if it is okay the way it is, just close it.